[Sync] Clean up notifications tab in chrome://sync-internals

[Sync] Clean up notifications tab in chrome://sync-internals

Pre-fill the notification info map with all known data types.

Combine the two notification tables into one.

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85234

[akalin, 2011-05-12 21:13:31]

+nzea for review

[Nicolas Zea, 2011-05-12 23:38:09]

http://codereview.chromium.org/7015031/diff/1/chrome/browser/resources/sync_i...
File chrome/browser/resources/sync_internals/notifications.html (right):

http://codereview.chromium.org/7015031/diff/1/chrome/browser/resources/sync_i...
chrome/browser/resources/sync_internals/notifications.html:41:
chrome.sync.notifications[k].type = k;
Is this information not in the original notificationInfo, and hence not merged
in?

http://codereview.chromium.org/7015031/diff/1/chrome/browser/resources/sync_i...
chrome/browser/resources/sync_internals/notifications.html:48:
chrome.sync.notifications[changedType].sessionCount =
Is it possible this data will be overwritten when merged into (in the above
method)? Does that matter?

[akalin, 2011-05-13 00:10:18]

PTAL

http://codereview.chromium.org/7015031/diff/1/chrome/browser/resources/sync_i...
File chrome/browser/resources/sync_internals/notifications.html (right):

http://codereview.chromium.org/7015031/diff/1/chrome/browser/resources/sync_i...
chrome/browser/resources/sync_internals/notifications.html:41:
chrome.sync.notifications[k].type = k;
On 2011/05/12 23:38:09, nzea wrote:
> Is this information not in the original notificationInfo, and hence not merged
> in?

It is, but only as the key.  I'm stuffing it into the value dictionary here just
for convenience when applying the jstemplate below.  (Added comment above)

http://codereview.chromium.org/7015031/diff/1/chrome/browser/resources/sync_i...
chrome/browser/resources/sync_internals/notifications.html:48:
chrome.sync.notifications[changedType].sessionCount =
On 2011/05/12 23:38:09, nzea wrote:
> Is it possible this data will be overwritten when merged into (in the above
> method)? Does that matter?

No, because we don't only the sessionCount in this javascript code.  (Added
comment above)

[Nicolas Zea, 2011-05-13 00:46:11]

LGTM.