Converted from DOM to WebUI for new login method

Converted from DOM to WebUI for new login method

This patch refactors the use of DOM to WebUI in the DOM/WebUI based login. This includes renaming relevant files, functions, and classes. In addition calls to this code has been updated along with the comments. The flag --dom-login has been changed to --webui-login.

This CL depends on http://codereview.chromium.org/6973029/.

Patch from Ryan Harrison <rharrison@chromium.org>;

BUG=none
TEST=manual

[Nikita (slow), 2011-05-13 07:13:30]

>> Converted from DOM to WebUI for new login method 

You're not actually changing the way it's implemented but just renaming, right?

[rharrison, 2011-05-17 23:24:18]

On 2011/05/13 07:13:30, Nikita Kostylev wrote:
> >> Converted from DOM to WebUI for new login method 
> 
> You're not actually changing the way it's implemented but just renaming,
right?
That is correct... This CL is currently stalled on resolving
http://codereview.chromium.org/6973029/. I am expecting a major reworking of it
to occur.

[oshima, 2011-05-19 22:40:55]

On 2011/05/17 23:24:18, rharrison wrote:
> On 2011/05/13 07:13:30, Nikita Kostylev wrote:
> > >> Converted from DOM to WebUI for new login method 
> > 
> > You're not actually changing the way it's implemented but just renaming,
> right?
> That is correct... This CL is currently stalled on resolving
> http://codereview.chromium.org/6973029/. I am expecting a major reworking of
it
> to occur.

ping me once the above CL is submitted.

[rharrison, 2011-05-21 05:55:29]

Updated CL to reflect changes in http://codereview.chromium.org/6973029/

[oshima, 2011-05-21 16:35:37]

LGTM with nits

http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/webui_login_display.h (right):

http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/webui_login_display.h:24: class WebUIBrowser;
looks like this is not used

http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/webui_login_display_host.cc (right):

http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/webui_login_display_host.cc:3: // found in the
LICENSE file.
looks like you deleted domui_login_display_host.cc and added new file. Instead,
you should use git-mv to preserve history. It'll make review easier.

[Ben Goodger (Google), 2011-05-21 17:11:14]

LGTM also for the rename. Thanks for cleaning this up.

-Ben


On 2011/05/21 16:35:37, oshima wrote:
> LGTM with nits
> 
>
http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
> File chrome/browser/chromeos/login/webui_login_display.h (right):
> 
>
http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
> chrome/browser/chromeos/login/webui_login_display.h:24: class WebUIBrowser;
> looks like this is not used
> 
>
http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
> File chrome/browser/chromeos/login/webui_login_display_host.cc (right):
> 
>
http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
> chrome/browser/chromeos/login/webui_login_display_host.cc:3: // found in the
> LICENSE file.
> looks like you deleted domui_login_display_host.cc and added new file.
Instead,
> you should use git-mv to preserve history. It'll make review easier.

[Nikita (slow), 2011-05-22 20:20:43]

LGTM

[rharrison, 2011-05-25 18:10:43]

http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/webui_login_display.h (right):

http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/webui_login_display.h:24: class WebUIBrowser;
On 2011/05/21 16:35:37, oshima wrote:
> looks like this is not used

Done.

http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/webui_login_display_host.cc (right):

http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/webui_login_display_host.cc:3: // found in the
LICENSE file.
On 2011/05/21 16:35:37, oshima wrote:
> looks like you deleted domui_login_display_host.cc and added new file.
Instead,
> you should use git-mv to preserve history. It'll make review easier.

I redid the the git mv since I agreed with you that this didn't seem correct.
When I committed it locally the git mv for this file was broken into a delete
and a create. This I think it happening since I am touching almost all the
content. Other then breaking up the git mv and editing the files into two
commits and hoping that upload doesn't do the same thing as a single commit is
there a way to force git to not do this?

[rharrison, 2011-05-25 18:56:27]

I messed up my patch set #3 badly. I have removed it and will publish a new
message when I up uploaded a good version of it.

On 2011/05/25 18:10:43, rharrison wrote:
>
http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
> File chrome/browser/chromeos/login/webui_login_display.h (right):
> 
>
http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
> chrome/browser/chromeos/login/webui_login_display.h:24: class WebUIBrowser;
> On 2011/05/21 16:35:37, oshima wrote:
> > looks like this is not used
> 
> Done.
> 
>
http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
> File chrome/browser/chromeos/login/webui_login_display_host.cc (right):
> 
>
http://codereview.chromium.org/7015024/diff/5001/chrome/browser/chromeos/logi...
> chrome/browser/chromeos/login/webui_login_display_host.cc:3: // found in the
> LICENSE file.
> On 2011/05/21 16:35:37, oshima wrote:
> > looks like you deleted domui_login_display_host.cc and added new file.
> Instead,
> > you should use git-mv to preserve history. It'll make review easier.
> 
> I redid the the git mv since I agreed with you that this didn't seem correct.
> When I committed it locally the git mv for this file was broken into a delete
> and a create. This I think it happening since I am touching almost all the
> content. Other then breaking up the git mv and editing the files into two
> commits and hoping that upload doesn't do the same thing as a single commit is
> there a way to force git to not do this?

[rharrison, 2011-05-25 20:37:56]

Updated a correct verison of patch #3

I attempted to git mv chrome/browser/chromeos/login/webui_login_display_host.cc,
then commit and then edit it. This still caused the issue with on upload it
being deleted and added.

[commit-bot: I haz the power, 2011-05-27 17:56:51]

Can't process patch for file
chrome/browser/chromeos/login/webui_login_display_host.h.
A +