Split the policy refresh rate preference into user- and device-policy refresh rate.

chrome/browser/policy/cloud_policy_subsystem.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/cloud_policy_subsystem.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/command_line.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/policy/cloud_policy_cache_base.h"
 #include "chrome/browser/policy/cloud_policy_controller.h"
 #include "chrome/browser/policy/cloud_policy_identity_strategy.h"
 #include "chrome/browser/policy/configuration_policy_provider.h"
 #include "chrome/browser/policy/device_management_service.h"
 #include "chrome/browser/policy/device_token_fetcher.h"
 #include "chrome/browser/policy/policy_notifier.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
@@ skipping 22 matching lines @@
   policy_notifier_->AddObserver(observer);
 }
 
 CloudPolicySubsystem::ObserverRegistrar::~ObserverRegistrar() {
   if (policy_notifier_)
     policy_notifier_->RemoveObserver(observer_);
 }
 
 CloudPolicySubsystem::CloudPolicySubsystem(
     CloudPolicyIdentityStrategy* identity_strategy,
-    CloudPolicyCacheBase* policy_cache)
-    : prefs_(NULL) {
+    CloudPolicyCacheBase* policy_cache) {
   net::NetworkChangeNotifier::AddIPAddressObserver(this);
   notifier_.reset(new PolicyNotifier());
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kDeviceManagementUrl)) {
     device_management_service_.reset(new DeviceManagementService(
         command_line->GetSwitchValueASCII(switches::kDeviceManagementUrl)));
     cloud_policy_cache_.reset(policy_cache);
     cloud_policy_cache_->set_policy_notifier(notifier_.get());
     cloud_policy_cache_->Load();
 
     device_token_fetcher_.reset(
         new DeviceTokenFetcher(device_management_service_.get(),
                                cloud_policy_cache_.get(),
                                notifier_.get()));
 
     cloud_policy_controller_.reset(
         new CloudPolicyController(device_management_service_.get(),
                                   cloud_policy_cache_.get(),
                                   device_token_fetcher_.get(),
                                   identity_strategy,
                                   notifier_.get()));
   }
 }
 
 CloudPolicySubsystem::~CloudPolicySubsystem() {
-  DCHECK(!prefs_);
   cloud_policy_controller_.reset();
   device_token_fetcher_.reset();
   cloud_policy_cache_.reset();
   device_management_service_.reset();
   net::NetworkChangeNotifier::RemoveIPAddressObserver(this);
 }
 
 void CloudPolicySubsystem::OnIPAddressChanged() {
   if (state() == CloudPolicySubsystem::NETWORK_ERROR &&
       cloud_policy_controller_.get()) {
     cloud_policy_controller_->Retry();
   }
 }
 
-void CloudPolicySubsystem::Initialize(
-    PrefService* prefs,
+void CloudPolicySubsystem::Initialize(const char* policy_refresh_name,

[Mattias Nissler (ping if slow), 2011/05/13 09:45:03]

Indentation

[sfeuz, 2011/05/17 14:27:42]

Done.

     net::URLRequestContextGetter* request_context) {
-  DCHECK(!prefs_);
-  prefs_ = prefs;
-
   if (device_management_service_.get())
     device_management_service_->Initialize(request_context);
 
-  policy_refresh_rate_.Init(prefs::kPolicyRefreshRate, prefs_, this);
+  DCHECK(std::string(policy_refresh_name) ==
+         std::string(prefs::kUserPolicyRefreshRate) ||
+         std::string(policy_refresh_name) ==
+         std::string(prefs::kDevicePolicyRefreshRate));

[Mattias Nissler (ping if slow), 2011/05/13 09:45:03]

Why this DCHECK? The subsystem doesn't care what policy name to use. If you
really want this semantics I suggest passing in an enum value as selector rather
than a string.

[sfeuz, 2011/05/17 14:27:42]

Done.

+  policy_refresh_rate_.Init(policy_refresh_name,
+                            g_browser_process->local_state(),
+                            this);
+
   UpdatePolicyRefreshRate();
 }
 
 void CloudPolicySubsystem::Shutdown() {
   if (device_management_service_.get())
     device_management_service_->Shutdown();
   cloud_policy_controller_.reset();
   cloud_policy_cache_.reset();
   policy_refresh_rate_.Destroy();
-  prefs_ = NULL;
 }
 
 CloudPolicySubsystem::PolicySubsystemState CloudPolicySubsystem::state() {
   return notifier_->state();
 }
 
 CloudPolicySubsystem::ErrorDetails CloudPolicySubsystem::error_details() {
   return notifier_->error_details();
 }
 
@@ skipping 12 matching lines @@
 ConfigurationPolicyProvider*
     CloudPolicySubsystem::GetRecommendedPolicyProvider() {
   if (cloud_policy_cache_.get())
     return cloud_policy_cache_->GetRecommendedPolicyProvider();
 
   return NULL;
 }
 
 // static
 void CloudPolicySubsystem::RegisterPrefs(PrefService* pref_service) {
-  pref_service->RegisterIntegerPref(prefs::kPolicyRefreshRate,
+  pref_service->RegisterIntegerPref(prefs::kDevicePolicyRefreshRate,
+                                    kDefaultPolicyRefreshRateMs,
+                                    PrefService::UNSYNCABLE_PREF);
+  pref_service->RegisterIntegerPref(prefs::kUserPolicyRefreshRate,
                                     kDefaultPolicyRefreshRateMs,
                                     PrefService::UNSYNCABLE_PREF);
 }
 
 void CloudPolicySubsystem::UpdatePolicyRefreshRate() {
   if (cloud_policy_controller_.get()) {
     // Clamp to sane values.
     int64 refresh_rate = policy_refresh_rate_.GetValue();
     refresh_rate = std::max(kPolicyRefreshRateMinMs, refresh_rate);
     refresh_rate = std::min(kPolicyRefreshRateMaxMs, refresh_rate);
     cloud_policy_controller_->SetRefreshRate(refresh_rate);
   }
 }
 
 void CloudPolicySubsystem::Observe(NotificationType type,
                                    const NotificationSource& source,
                                    const NotificationDetails& details) {
   if (type == NotificationType::PREF_CHANGED &&
       policy_refresh_rate_.GetPrefName() ==
-          *(Details<std::string>(details).ptr()) &&
-      prefs_ == Source<PrefService>(source).ptr()) {
+      *(Details<std::string>(details).ptr())) {
+    DCHECK(Source<PrefService>(source).ptr() ==

[Mattias Nissler (ping if slow), 2011/05/13 09:45:03]

Why not use DCHECK_EQ?

[sfeuz, 2011/05/17 14:27:42]

Done.

+           g_browser_process->local_state());
     UpdatePolicyRefreshRate();
   } else {
     NOTREACHED();
   }
 }
 
 }  // namespace policy