Support conversion of clamped double values for pixel arrays in Crankshaft.

test/mjsunit/external-array.js

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 66 matching lines @@
   assertEquals(3.5, array[1]);
 }
 %OptimizeFunctionOnNextCall(get);
 assertEquals(2.5, get(array, 0));
 assertEquals(3.5, get(array, 1));
 
 // Test loads and stores.
 types = [Int8Array, Uint8Array, Int16Array, Uint16Array, Int32Array,
          Uint32Array, PixelArray, Float32Array, Float64Array];
 
+test_result_nan = [0, 0, 0, 0, 0, 0, 0, NaN, NaN];
+test_result_low_double = [-1, 255, -1, 65535, -1, 0xFFFFFFFF, 0, -1.25, -1.25];
+test_result_low_int = [-1, 255, -1, 65535, -1, 0xFFFFFFFF, 0, -1, -1];
+test_result_middle = [-3, 253, 253, 253, 253, 253, 254, 253.75, 253.75];
+test_result_high_int = [0, 0, 256, 256, 256, 256, 255, 256, 256];
+test_result_high_double = [0, 0, 256, 256, 256, 256, 255, 256.25, 256.25];
+
 const kElementCount = 40;
 
 function test_load(array, sum) {
   for (var i = 0; i < kElementCount; i++) {
     sum += array[i];
   }
   return sum;
 }
 
 function test_load_const_key(array, sum) {
@@ skipping 10 matching lines @@
   return sum;
 }
 
 function test_store_const_key(array, sum) {
   sum += array[0] = 1;
   sum += array[1] = 2;
   sum += array[2] = 3;
   return sum;
 }
 
-function run_test(test_func, array, expected_sum_per_run) {
+
+function test_store_middle_double(array, sum) {
+  array[0] = 253.75;
+  return array[0];
+}
+
+
+function test_store_high_double(array, sum) {
+  array[0] = 256.25;
+  return array[0];
+}
+
+function test_store_high_int(array, sum) {
+  array[0] = 256;
+  return array[0];
+}
+
+function test_store_low_double(array, sum) {
+  array[0] = -1.25;
+  return array[0];
+}
+
+function test_store_low_int(array, sum) {
+  array[0] = -1;
+  return array[0];
+}
+
+function test_store_nan(array, sum) {
+  array[0] = NaN;
+  return array[0];
+}
+

[Lasse Reichstein, 2011/05/13 13:17:24]

Test 0.49999999999999994, please :).

And both 1.5 and 2.5.

[danno, 2011/05/15 05:50:27]

I'm not so sure we should add the test case, since the rest of the
implementation for CanvasPixelArrays uses the incorrect +.5 semantics and
already did "before my time". :-) I suggest staying consistent until it gets
fixed everywhere, and I don't think it's a good idea to bake in an incorrect
test case.

I promise to add the test case when I fix the bug (issue 1392). :-)

On 2011/05/13 13:17:24, Lasse Reichstein wrote:

[Lasse Reichstein, 2011/05/15 10:18:51]

That's fine.
If you have a test that is known to fail for now, you can add a test file in
mjsunit/bugs. It'll default to expecting to fail, and can be moved to
mjsunit/regress when the bug is fixed.

[danno, 2011/05/16 14:13:43]

I'll write and submit the test in a separate CL.
 On 2011/05/13 13:17:24, Lasse Reichstein wrote:

+const kRuns = 10;
+
+function run_test(test_func, array, expected_result) {
   for (var i = 0; i < 5; i++) test_func(array, 0);
   %OptimizeFunctionOnNextCall(test_func);
-  const kRuns = 10;
   var sum = 0;
   for (var i = 0; i < kRuns; i++) {
     sum = test_func(array, sum);
   }
-  assertEquals(sum, expected_sum_per_run * kRuns);
+  assertEquals(expected_result, sum);
   %DeoptimizeFunction(test_func);
   gc();  // Makes V8 forget about type information for test_func.
 }
 
 for (var t = 0; t < types.length; t++) {
   var type = types[t];
   var a = new type(kElementCount);
   for (var i = 0; i < kElementCount; i++) {
     a[i] = i;
   }
-  
+
   // Run test functions defined above.
-  run_test(test_load, a, 780);
-  run_test(test_load_const_key, a, 3);
-  run_test(test_store, a, 820);
-  run_test(test_store_const_key, a, 6);
-  
+  run_test(test_load, a, 780 * kRuns);
+  run_test(test_load_const_key, a, 3 * kRuns);
+  run_test(test_store, a, 820 * kRuns);
+  run_test(test_store_const_key, a, 6 * kRuns);
+  run_test(test_store_low_double, a, test_result_low_double[t]);
+  run_test(test_store_low_int, a, test_result_low_int[t]);
+  run_test(test_store_high_double, a, test_result_high_double[t]);
+  run_test(test_store_high_int, a, test_result_high_int[t]);
+  run_test(test_store_nan, a, test_result_nan[t]);
+  run_test(test_store_middle_double, a, test_result_middle[t]);
+
   // Test the correct behavior of the |length| property (which is read-only).
   assertEquals(kElementCount, a.length);
   a.length = 2;
   assertEquals(kElementCount, a.length);
   assertTrue(delete a.length);
   a.length = 2
   assertEquals(2, a.length);
 }