Issue 7014: Make strict equality checks faster on IA32 by doing...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7014: Make strict equality checks faster on IA32 by doing... (Closed)

Created:
12 years, 2 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
bak

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make strict equality checks faster on IA32 by doing more work in the CompareStub. I'll port this to ARM once I'm satisfied with the performance improvements. Committed: http://code.google.com/p/v8/source/detail?r=481

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -17 lines)			Patch
	M	src/codegen-ia32.cc	View		3 chunks	+74 lines, -3 lines	0 comments	Download
	M	src/runtime.js	View		1 chunk	+7 lines, -14 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bak

12 years, 2 months ago (2008-10-10 06:23:44 UTC) #2

LGTM,
  Lars

http://codereview.chromium.org/7014/diff/1/2
File src/runtime.js (right):

http://codereview.chromium.org/7014/diff/1/2#newcode97
Line 97: } else if (IS_STRING(this)) {
What is up with excessive use of else parts.
return breaks the control flow.

Expand Messages | Collapse Messages