Add information about sync session and other useful data to about:sync.

chrome/browser/sync/engine/all_status.cc

Index: chrome/browser/sync/engine/all_status.cc
diff --git a/chrome/browser/sync/engine/all_status.cc b/chrome/browser/sync/engine/all_status.cc
index 83d148abf0d04c88875f73b4b76eb30fe9c4231d..ed6aa7cef1a85f271ac642acf8f3059fd8eb5884 100644
--- a/chrome/browser/sync/engine/all_status.cc
+++ b/chrome/browser/sync/engine/all_status.cc
@@ -79,6 +79,12 @@ sync_api::SyncManager::Status AllStatus::CalcSyncing(
         snapshot->syncer_status.num_local_overwrites;
     status.num_server_overwrites_total +=
         snapshot->syncer_status.num_server_overwrites;
+    if (snapshot->syncer_status.num_successful_commits == 0 &&
+        snapshot->syncer_status.num_updates_downloaded_total == 0) {
+      ++status.empty_getupdates;

[akalin, 2011/05/13 22:01:42]

getupdates -> get_updates

[lipalani1, 2011/05/13 22:35:39]

Done.

+    } else {
+      ++status.nonempty_getupdates;

[akalin, 2011/05/13 22:01:42]

can't num_successful_commits be non-zero, i.e. can't this be a commit?

[lipalani1, 2011/05/13 22:35:39]

Not sure i understand. if the commits is zero and download is zero then we count
this as a non emtpy get update.
On 2011/05/13 22:01:42, akalin wrote:

[akalin, 2011/05/16 22:11:23]

I mean if the download count is 0 and the commit count is >0, isn't that a
commit, and not a getupdates?

On 2011/05/13 22:35:39, lipalani1 wrote:

[ncarter (slow), 2011/05/16 22:57:50]

I also don't understand why the commit counter factors into the determination of
the empty_getupdates counter.  Moreover, I would want for these counters to
count the number of GetUpdates requests, not the number of sync cycles.  A sync
cycle can do arbitrarily many GetUpdates requests.

+    }
   }
   return status;
 }