Issue 7013024: ARM: Fix disasm for strh, vabs, vneg. Add load/store tests....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7013024: ARM: Fix disasm for strh, vabs, vneg. Add load/store tests.... (Closed)

Created:
9 years, 7 months ago by m.m.capewell

Modified:
9 years, 7 months ago

Reviewers:
Karl Klose

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Fix disasm for strh, vabs, vneg. Add load/store tests. BUG=none TEST=added to test/cctest/test-disasm-arm.cc Patch from ARM Ltd.

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -12 lines)			Patch
	M	src/arm/disasm-arm.cc	View		2 chunks	+11 lines, -8 lines	0 comments	Download
	M	test/cctest/test-disasm-arm.cc	View	1	2 chunks	+228 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Karl Klose

9 years, 7 months ago (2011-05-12 14:44:18 UTC) #4

The new test fails asserts, because it does not use check for availability of
ARMv7 and it uses two register MemOperands for ldrd/strd, which is currently not
supported in the assembler.

I have added the feature check and scope and removed the invalid tests in the
following CL: http://codereview.chromium.org/7013027/.

Expand Messages | Collapse Messages