Autofill should reject aggregated profiles where email address is found in non-email fields

Autofill should reject aggregated profiles where email address is found in non-email fields

Adds code to reject import of profiles and credit cards that have email address data in non-email fields.

BUG=77113
TEST=AutofillMergeTest.DataDrivenMergeProfiles with email.in and email.out.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85489

[Ilya Sherman, 2011-05-12 21:40:03]

http://codereview.chromium.org/7013016/diff/2001/chrome/browser/autofill/pers...
File chrome/browser/autofill/personal_data_manager.cc (right):

http://codereview.chromium.org/7013016/diff/2001/chrome/browser/autofill/pers...
chrome/browser/autofill/personal_data_manager.cc:123: return false;
It's a little confusing to me that this check is here, but the complementary
check is in IsValidLearnableProfile().  If you're not opposed, let's have them
live side by side -- either here or there is fine by me.

[dhollowa, 2011-05-12 23:24:11]

http://codereview.chromium.org/7013016/diff/2001/chrome/browser/autofill/pers...
File chrome/browser/autofill/personal_data_manager.cc (right):

http://codereview.chromium.org/7013016/diff/2001/chrome/browser/autofill/pers...
chrome/browser/autofill/personal_data_manager.cc:123: return false;
On 2011/05/12 21:40:03, Ilya Sherman wrote:
> It's a little confusing to me that this check is here, but the complementary
> check is in IsValidLearnableProfile().  If you're not opposed, let's have them
> live side by side -- either here or there is fine by me.

Done.

[Ilya Sherman, 2011-05-12 23:53:38]

LGTM, thanks :)

[dhollowa, 2011-05-13 02:12:34]

On 2011/05/12 23:53:38, Ilya Sherman wrote:
> LGTM, thanks :)

I had to restore the original.  Forgot that the migration code needs the email
check in |IsValidLearnableProfile|.

[Ilya Sherman, 2011-05-13 06:33:01]

On 2011/05/13 02:12:34, dhollowa wrote:
> On 2011/05/12 23:53:38, Ilya Sherman wrote:
> > LGTM, thanks :)
> 
> I had to restore the original.  Forgot that the migration code needs the email
> check in |IsValidLearnableProfile|.

That suggests that the other check should also go in |IsValidLearnableProfile|
-- no?

[dhollowa, 2011-05-13 17:26:15]

On 2011/05/13 06:33:01, Ilya Sherman wrote:
> On 2011/05/13 02:12:34, dhollowa wrote:
> > On 2011/05/12 23:53:38, Ilya Sherman wrote:
> > > LGTM, thanks :)
> > 
> > I had to restore the original.  Forgot that the migration code needs the
email
> > check in |IsValidLearnableProfile|.
> 
> That suggests that the other check should also go in |IsValidLearnableProfile|
> -- no?

I'm reluctant to do that because then |IsValidLearnableProfile| needs to
replicate the traversal of the various fields.  This seems like overkill an
overly complicated.  Especially since the migration code has "set sail".  I
prefer it as it stands.