Issue 7013002: Only block the GPu process if WebGL, compositing or canvas2D are blacklisted (but not if multisam...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7013002: Only block the GPu process if WebGL, compositing or canvas2D are blacklisted (but not if multisam... (Closed)

Created:
9 years, 7 months ago by Vangelis Kokkevis

Modified:
9 years, 6 months ago

Reviewers:
vangelis, Ken Russell (switch to Gerrit)

CC:
chromium-reviews, jam, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Only block the GPu process if WebGL, compositing or canvas2D are blacklisted (but not if multisampling is blacklisted). This allows us to run on Mac's with AMD h/w. BUG=82104 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85031

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	content/browser/gpu/gpu_data_manager.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

9 years, 7 months ago (2011-05-11 20:23:26 UTC) #2

LGTM but I think we should add a TODO at the top of this function since it
clearly needs rethinking -- if, say, only WebGL is blacklisted, we still need to
be able to launch the GPU process to run the compositor.

Expand Messages | Collapse Messages