Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 7012012: Only send null or undefined as receiver for es5 natives, not generally (Closed)

Created:
9 years, 7 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Only send null or undefined as receiver for es5 natives, not generally for builtin functions. Committed: http://code.google.com/p/v8/source/detail?r=7879

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -55 lines) Patch
M src/arm/builtins-arm.cc View 1 2 4 chunks +11 lines, -21 lines 0 comments Download
M src/heap.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 2 chunks +6 lines, -14 lines 0 comments Download
M src/objects.h View 1 3 chunks +21 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 2 chunks +6 lines, -13 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-1369.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Rico
9 years, 7 months ago (2011-05-12 16:48:28 UTC) #1
Mads Ager (chromium)
LGTM
9 years, 7 months ago (2011-05-13 05:47:33 UTC) #2
Rico
Updated tests on API added functions to expect that non objects are converted to the ...
9 years, 7 months ago (2011-05-13 05:58:27 UTC) #3
Mads Ager (chromium)
On 2011/05/13 05:58:27, Rico wrote: > Updated tests on API added functions to expect that ...
9 years, 7 months ago (2011-05-13 05:59:07 UTC) #4
Rico
Added arm and x64 implementations
9 years, 7 months ago (2011-05-13 07:23:57 UTC) #5
Mads Ager (chromium)
9 years, 7 months ago (2011-05-13 07:25:51 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698