Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 7012010: Don't use environment values at certain deoptimize-instructions. (Closed)

Created:
9 years, 7 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Don't use environment values at certain deoptimize-instructions. If a HDeoptimize does not cut away parts of the control-flow-graph we don't need to insert uses to correctly elimiate dead phis since the full function is visible to the optimizing compiler. This is a small improvement of the change r7221 which fixed a problem when deoptimizing on never executed case-clauses. Committed: http://code.google.com/p/v8/source/detail?r=7877

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M src/hydrogen.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 1 4 chunks +9 lines, -6 lines 0 comments Download
M src/hydrogen-instructions.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 7 months ago (2011-05-12 14:22:19 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 7 months ago (2011-05-12 14:32:59 UTC) #2
LGTM

http://codereview.chromium.org/7012010/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

http://codereview.chromium.org/7012010/diff/1/src/hydrogen.h#newcode128
src/hydrogen.h:128: void FinishExitWithDeoptimization(bool use_environment) {
Can you use enum instead of boolean?

Powered by Google App Engine
This is Rietveld 408576698