Chrome side of having the WebKit FileSystem API use WebPermissionClient for checking if using fil...

Chrome side of having the WebKit FileSystem API use WebPermissionClient for checking if using file system is fine.  Depends on https://bugs.webkit.org/show_bug.cgi?id=60683

BUG=76793
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85153

[jam, 2011-05-12 02:18:36]

I only need one of you to review, so whoever gets to it first.

[michaeln, 2011-05-12 02:57:18]

Thnx for taking care this!

http://codereview.chromium.org/7012007/diff/1/content/browser/file_system/fil...
File content/browser/file_system/file_system_dispatcher_host.h (left):

http://codereview.chromium.org/7012007/diff/1/content/browser/file_system/fil...
content/browser/file_system/file_system_dispatcher_host.h:43:
HostContentSettingsMap* host_content_settings_map);
nice!

http://codereview.chromium.org/7012007/diff/5004/content/worker/webworkerclie...
File content/worker/webworkerclient_proxy.cc (right):

http://codereview.chromium.org/7012007/diff/5004/content/worker/webworkerclie...
content/worker/webworkerclient_proxy.cc:160: WebSecurityOrigin origin =
frame->securityOrigin();
frame not needed, see see stub_->url().GetOrigin() as used in openFileSystem()

[ericu, 2011-05-12 16:38:23]

I'm not quite following this.

I see WorkerProcessHost::onAllowFileSystem that always returns true, but
ChromeWorkerMessageFilter::onAllowFileSystem and the one in
ChromeRenderMessageFilter that actually look up permissions.  Is the
WorkerProcessHost one ever called?

[jam, 2011-05-12 16:40:34]

http://codereview.chromium.org/7012007/diff/5004/content/worker/webworkerclie...
File content/worker/webworkerclient_proxy.cc (right):

http://codereview.chromium.org/7012007/diff/5004/content/worker/webworkerclie...
content/worker/webworkerclient_proxy.cc:160: WebSecurityOrigin origin =
frame->securityOrigin();
On 2011/05/12 02:57:19, michaeln wrote:
> frame not needed, see see stub_->url().GetOrigin() as used in openFileSystem()

Done.

[jam, 2011-05-12 16:42:01]

On 2011/05/12 16:38:23, ericu wrote:
> I'm not quite following this.
> 
> I see WorkerProcessHost::onAllowFileSystem that always returns true, but
> ChromeWorkerMessageFilter::onAllowFileSystem and the one in
> ChromeRenderMessageFilter that actually look up permissions.  Is the
> WorkerProcessHost one ever called?

WorkerProcessHost::onAllowFileSystem is there so that if anyone builds a browser
using just content, i.e. our planned multi-process test shell, then things work.
 Since in that case, there'll be no ChromeWorkerMessageFilter so otherwise the
renderer/worker will be hung waiting for a reply.  In Chrome's case,
ChromeRenderMessageFilter swallows the message when it dispatches it, so it
never gets to WorkerProcessHost

[michaeln, 2011-05-12 18:09:17]

lgtm