Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: chrome/browser/sync/glue/bookmark_change_processor.cc

Issue 7012005: Revert "Revert 84829 - Initial implementation of "Synced Bookmarks" folder." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Trying to set .json eol-style Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/bookmark_change_processor.cc
diff --git a/chrome/browser/sync/glue/bookmark_change_processor.cc b/chrome/browser/sync/glue/bookmark_change_processor.cc
index a82291b4847a25980372ee3c53e0dfd346f759ba..b7418ceb5697c35a6ed93a439968a689693a8276 100644
--- a/chrome/browser/sync/glue/bookmark_change_processor.cc
+++ b/chrome/browser/sync/glue/bookmark_change_processor.cc
@@ -188,10 +188,10 @@ void BookmarkChangeProcessor::BookmarkNodeRemoved(BookmarkModel* model,
}
void BookmarkChangeProcessor::BookmarkNodeChanged(BookmarkModel* model,
- const BookmarkNode* node) {
+ const BookmarkNode* node) {
DCHECK(running());
// We shouldn't see changes to the top-level nodes.
- if (node == model->GetBookmarkBarNode() || node == model->other_node()) {
+ if (model->is_permanent_node(node)) {
NOTREACHED() << "Saw update to permanent node!";
return;
}
@@ -225,7 +225,7 @@ void BookmarkChangeProcessor::BookmarkNodeMoved(BookmarkModel* model,
DCHECK(running());
const BookmarkNode* child = new_parent->GetChild(new_index);
// We shouldn't see changes to the top-level nodes.
- if (child == model->GetBookmarkBarNode() || child == model->other_node()) {
+ if (model->is_permanent_node(child)) {
NOTREACHED() << "Saw update to permanent node!";
return;
}
@@ -384,7 +384,7 @@ void BookmarkChangeProcessor::ApplyChangesFromSyncModel(
model_associator_->GetChromeNodeFromSyncId(changes[i].id);
// Ignore changes to the permanent top-level nodes. We only care about
// their children.
- if ((dst == model->GetBookmarkBarNode()) || (dst == model->other_node()))
+ if (model->is_permanent_node(dst))
continue;
if (changes[i].action ==
sync_api::SyncManager::ChangeRecord::ACTION_DELETE) {
@@ -392,7 +392,6 @@ void BookmarkChangeProcessor::ApplyChangesFromSyncModel(
DCHECK(i == 0 || changes[i-1].action == changes[i].action);
// Children of a deleted node should not be deleted; they may be
// reparented by a later change record. Move them to a temporary place.
- DCHECK(dst) << "Could not find node to be deleted";
if (!dst) // Can't do anything if we can't find the chrome node.
continue;
const BookmarkNode* parent = dst->parent();
« no previous file with comments | « chrome/browser/sync/engine/download_updates_command.cc ('k') | chrome/browser/sync/glue/bookmark_model_associator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698