Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1837)

Unified Diff: chrome/browser/extensions/extension_bookmarks_module.cc

Issue 7012005: Revert "Revert 84829 - Initial implementation of "Synced Bookmarks" folder." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Trying to set .json eol-style Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_bookmark_helpers.cc ('k') | chrome/browser/history/history_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_bookmarks_module.cc
diff --git a/chrome/browser/extensions/extension_bookmarks_module.cc b/chrome/browser/extensions/extension_bookmarks_module.cc
index 1777e790c785fbc5cd0ab8468b347c3b5339a48c..6d9a5c190879489e19dfbca4bdcd01d78b8b6cc7 100644
--- a/chrome/browser/extensions/extension_bookmarks_module.cc
+++ b/chrome/browser/extensions/extension_bookmarks_module.cc
@@ -521,9 +521,7 @@ bool MoveBookmarkFunction::RunImpl() {
error_ = keys::kNoNodeError;
return false;
}
- if (node == model->root_node() ||
- node == model->other_node() ||
- node == model->GetBookmarkBarNode()) {
+ if (model->is_permanent_node(node)) {
error_ = keys::kModifySpecialError;
return false;
}
@@ -615,9 +613,7 @@ bool UpdateBookmarkFunction::RunImpl() {
error_ = keys::kNoNodeError;
return false;
}
- if (node == model->root_node() ||
- node == model->other_node() ||
- node == model->GetBookmarkBarNode()) {
+ if (model->is_permanent_node(node)) {
error_ = keys::kModifySpecialError;
return false;
}
« no previous file with comments | « chrome/browser/extensions/extension_bookmark_helpers.cc ('k') | chrome/browser/history/history_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698