Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk_unittest.cc

Issue 7012005: Revert "Revert 84829 - Initial implementation of "Synced Bookmarks" folder." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix memory allocation of gtk iterator Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <gtk/gtk.h> 5 #include <gtk/gtk.h>
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 // a 64 // a
65 // F1 65 // F1
66 // f1a 66 // f1a
67 // F11 67 // F11
68 // f11a 68 // f11a
69 // F2 69 // F2
70 // other node 70 // other node
71 // oa 71 // oa
72 // OF1 72 // OF1
73 // of1a 73 // of1a
74 // synced node
75 // sa
74 void AddTestData() { 76 void AddTestData() {
75 std::string test_base = base_path(); 77 std::string test_base = base_path();
76 78
77 model_->AddURL(model_->GetBookmarkBarNode(), 0, ASCIIToUTF16("a"), 79 model_->AddURL(model_->GetBookmarkBarNode(), 0, ASCIIToUTF16("a"),
78 GURL(test_base + "a")); 80 GURL(test_base + "a"));
79 const BookmarkNode* f1 = 81 const BookmarkNode* f1 =
80 model_->AddFolder(model_->GetBookmarkBarNode(), 1, ASCIIToUTF16("F1")); 82 model_->AddFolder(model_->GetBookmarkBarNode(), 1, ASCIIToUTF16("F1"));
81 model_->AddURL(f1, 0, ASCIIToUTF16("f1a"), GURL(test_base + "f1a")); 83 model_->AddURL(f1, 0, ASCIIToUTF16("f1a"), GURL(test_base + "f1a"));
82 const BookmarkNode* f11 = model_->AddFolder(f1, 1, ASCIIToUTF16("F11")); 84 const BookmarkNode* f11 = model_->AddFolder(f1, 1, ASCIIToUTF16("F11"));
83 model_->AddURL(f11, 0, ASCIIToUTF16("f11a"), GURL(test_base + "f11a")); 85 model_->AddURL(f11, 0, ASCIIToUTF16("f11a"), GURL(test_base + "f11a"));
84 model_->AddFolder(model_->GetBookmarkBarNode(), 2, ASCIIToUTF16("F2")); 86 model_->AddFolder(model_->GetBookmarkBarNode(), 2, ASCIIToUTF16("F2"));
85 87
86 // Children of the other node. 88 // Children of the other node.
87 model_->AddURL(model_->other_node(), 0, ASCIIToUTF16("oa"), 89 model_->AddURL(model_->other_node(), 0, ASCIIToUTF16("oa"),
88 GURL(test_base + "oa")); 90 GURL(test_base + "oa"));
89 const BookmarkNode* of1 = 91 const BookmarkNode* of1 =
90 model_->AddFolder(model_->other_node(), 1, ASCIIToUTF16("OF1")); 92 model_->AddFolder(model_->other_node(), 1, ASCIIToUTF16("OF1"));
91 model_->AddURL(of1, 0, ASCIIToUTF16("of1a"), GURL(test_base + "of1a")); 93 model_->AddURL(of1, 0, ASCIIToUTF16("of1a"), GURL(test_base + "of1a"));
94
95 // Children of the synced node.
96 model_->AddURL(model_->synced_node(), 0, ASCIIToUTF16("sa"),
97 GURL(test_base + "sa"));
92 } 98 }
93 }; 99 };
94 100
95 // Makes sure the tree model matches that of the bookmark bar model. 101 // Makes sure the tree model matches that of the bookmark bar model.
96 TEST_F(BookmarkEditorGtkTest, ModelsMatch) { 102 TEST_F(BookmarkEditorGtkTest, ModelsMatch) {
97 BookmarkEditorGtk editor(NULL, profile_.get(), NULL, 103 BookmarkEditorGtk editor(NULL, profile_.get(), NULL,
98 BookmarkEditor::EditDetails(), 104 BookmarkEditor::EditDetails(),
99 BookmarkEditor::SHOW_TREE); 105 BookmarkEditor::SHOW_TREE);
100 106
101 // The root should have two children, one for the bookmark bar node, 107 // The root should have two children, one for the bookmark bar node,
102 // the other for the 'other bookmarks' folder. 108 // the other for the 'other bookmarks' folder.
103 GtkTreeModel* store = GTK_TREE_MODEL(editor.tree_store_); 109 GtkTreeModel* store = GTK_TREE_MODEL(editor.tree_store_);
104 GtkTreeIter toplevel; 110 GtkTreeIter toplevel;
105 ASSERT_TRUE(gtk_tree_model_get_iter_first(store, &toplevel)); 111 ASSERT_TRUE(gtk_tree_model_get_iter_first(store, &toplevel));
106 GtkTreeIter bookmark_bar_node = toplevel; 112 GtkTreeIter bookmark_bar_node = toplevel;
107 ASSERT_TRUE(gtk_tree_model_iter_next(store, &toplevel)); 113 ASSERT_TRUE(gtk_tree_model_iter_next(store, &toplevel));
108 GtkTreeIter other_node = toplevel; 114 GtkTreeIter other_node = toplevel;
109 ASSERT_FALSE(gtk_tree_model_iter_next(store, &toplevel)); 115 ASSERT_FALSE(gtk_tree_model_iter_next(store, &toplevel));
110 116
111 // The bookmark bar should have 2 nodes: folder F1 and F2. 117 // The bookmark bar should have 2 nodes: folder F1 and F2.
112 GtkTreeIter f1_iter; 118 GtkTreeIter f1_iter;
113 GtkTreeIter child; 119 GtkTreeIter child;
114 ASSERT_EQ(2, gtk_tree_model_iter_n_children(store, &bookmark_bar_node)); 120 if (model_->synced_node()->IsVisible()) {
121 ASSERT_EQ(3, gtk_tree_model_iter_n_children(store, &bookmark_bar_node));
122 } else {
123 ASSERT_EQ(2, gtk_tree_model_iter_n_children(store, &bookmark_bar_node));
124 }
115 ASSERT_TRUE(gtk_tree_model_iter_children(store, &child, &bookmark_bar_node)); 125 ASSERT_TRUE(gtk_tree_model_iter_children(store, &child, &bookmark_bar_node));
116 f1_iter = child; 126 f1_iter = child;
117 ASSERT_EQ("F1", UTF16ToUTF8(GetTitleFromTreeIter(store, &child))); 127 ASSERT_EQ("F1", UTF16ToUTF8(GetTitleFromTreeIter(store, &child)));
118 ASSERT_TRUE(gtk_tree_model_iter_next(store, &child)); 128 ASSERT_TRUE(gtk_tree_model_iter_next(store, &child));
119 ASSERT_EQ("F2", UTF16ToUTF8(GetTitleFromTreeIter(store, &child))); 129 ASSERT_EQ("F2", UTF16ToUTF8(GetTitleFromTreeIter(store, &child)));
120 ASSERT_FALSE(gtk_tree_model_iter_next(store, &child)); 130 ASSERT_FALSE(gtk_tree_model_iter_next(store, &child));
121 131
122 // F1 should have one child, F11 132 // F1 should have one child, F11
123 ASSERT_EQ(1, gtk_tree_model_iter_n_children(store, &f1_iter)); 133 ASSERT_EQ(1, gtk_tree_model_iter_n_children(store, &f1_iter));
124 ASSERT_TRUE(gtk_tree_model_iter_children(store, &child, &f1_iter)); 134 ASSERT_TRUE(gtk_tree_model_iter_children(store, &child, &f1_iter));
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 gtk_entry_set_text(GTK_ENTRY(editor.name_entry_), "new_a"); 326 gtk_entry_set_text(GTK_ENTRY(editor.name_entry_), "new_a");
317 327
318 editor.ApplyEdits(); 328 editor.ApplyEdits();
319 329
320 const BookmarkNode* other_node = profile_->GetBookmarkModel()->other_node(); 330 const BookmarkNode* other_node = profile_->GetBookmarkModel()->other_node();
321 ASSERT_EQ(2, other_node->child_count()); 331 ASSERT_EQ(2, other_node->child_count());
322 332
323 const BookmarkNode* new_node = other_node->GetChild(0); 333 const BookmarkNode* new_node = other_node->GetChild(0);
324 EXPECT_EQ(ASCIIToUTF16("new_a"), new_node->GetTitle()); 334 EXPECT_EQ(ASCIIToUTF16("new_a"), new_node->GetTitle());
325 } 335 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698