Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3149)

Unified Diff: chrome/browser/ui/gtk/global_menu_bar.cc

Issue 7011052: Revert 85330 - GTK: Bring global menu out of about:flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/browser_window_gtk.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/global_menu_bar.cc
===================================================================
--- chrome/browser/ui/gtk/global_menu_bar.cc (revision 85340)
+++ chrome/browser/ui/gtk/global_menu_bar.cc (working copy)
@@ -56,13 +56,24 @@
{ MENU_END, MENU_END }
};
+// TODO(erg): Need to add support for undo/redo/other editing commands that
+// don't go through the command id framework.
GlobalMenuBarCommand edit_menu[] = {
+ // TODO(erg): Undo
+ // TODO(erg): Redo
+
+ // TODO(erg): Separator
+
{ IDS_CUT, IDC_CUT },
{ IDS_COPY, IDC_COPY },
{ IDS_PASTE, IDC_PASTE },
+ // TODO(erg): Delete
{ MENU_SEPARATOR, MENU_SEPARATOR },
+ // TODO(erg): Select All
+ // TODO(erg): Another separator
+
{ IDS_FIND, IDC_FIND },
{ MENU_SEPARATOR, MENU_SEPARATOR },
@@ -72,6 +83,8 @@
{ MENU_END, MENU_END }
};
+// TODO(erg): The View menu should be overhauled and based on the Firefox view
+// menu.
GlobalMenuBarCommand view_menu[] = {
{ IDS_SHOW_BOOKMARK_BAR, IDC_SHOW_BOOKMARK_BAR },
« no previous file with comments | « chrome/browser/ui/gtk/browser_window_gtk.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698