Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chrome/chrome_common.gypi

Issue 7011032: Make the gyp files more cross-platform across the Unices (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: updated to trunk and fixed some nits Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_common.gypi
diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi
index 1ae861b9c69421b05b9c7bc7dc1c4d714b06ea22..2a9b60aeb28442c2f8cdcd7a3f77692e7bc5ec64 100644
--- a/chrome/chrome_common.gypi
+++ b/chrome/chrome_common.gypi
@@ -256,7 +256,7 @@
'common/zip.h',
],
'conditions': [
- ['OS=="linux" or OS=="freebsd" or OS=="openbsd"', {
+ ['toolkit_uses_gtk==1', {
Evan Stade 2011/05/17 00:46:12 wow, we are really inconsistent about putting spac
'dependencies': [
'../build/linux/system.gyp:gtk',
],
@@ -272,7 +272,7 @@
],
},
},],
- [ 'OS == "linux" or OS == "freebsd" or OS == "openbsd" or OS == "solaris"', {
+ [ 'os_posix==1 and OS!="mac"', {
'include_dirs': [
'<(SHARED_INTERMEDIATE_DIR)',
],
@@ -387,7 +387,7 @@
'../third_party/icu/icu.gyp:icuuc',
],
'conditions': [
- [ 'OS == "linux" or OS == "freebsd" or OS == "openbsd"', {
+ [ 'os_posix==1 and OS!="mac"', {
Evan Stade 2011/05/17 00:46:12 I guess to be consistent there should be no space
'conditions': [
['use_openssl==1', {
'dependencies': [
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chrome/chrome_exe.gypi » ('j') | content/content_browser.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698