Chromium Code Reviews| Index: chrome/chrome_tests.gypi |
| diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi |
| index e5e38e7b163741510eaaf9da48af186ee885359d..fe95d1e27d1bd3c7e4b5463238e4d0ccb2e16c7f 100644 |
| --- a/chrome/chrome_tests.gypi |
| +++ b/chrome/chrome_tests.gypi |
| @@ -195,7 +195,7 @@ |
| '../ui/gfx/image_unittest_util.cc', |
| ], |
| 'conditions': [ |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../build/linux/system.gyp:nss', |
| @@ -250,7 +250,7 @@ |
| 'chrome.gyp:crash_service', # run time dependency |
| ], |
| }], |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| ], |
| @@ -335,7 +335,7 @@ |
| 'test/unit/run_all_unittests.cc', |
| ], |
| 'conditions': [ |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| # Needed for the following #include chain: |
| # test/unit/run_all_unittests.cc |
| @@ -382,7 +382,7 @@ |
| }, |
| }, |
| },], |
| - ['OS=="linux"', { |
| + ['use_x11==1', { |
| 'dependencies': [ |
| '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', |
| ], |
| @@ -455,14 +455,14 @@ |
| 'test/unit/chrome_test_suite.h', |
| ], |
| 'conditions': [ |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../build/linux/system.gyp:nss', |
| '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', |
| ], |
| }], |
| - ['OS=="linux" and toolkit_views==0', { |
| + ['toolkit_uses_gtk==1 and toolkit_views==0', { |
| 'sources!': [ |
| # TODO(port) |
| 'browser/ui/views/bookmarks/bookmark_bar_view_test.cc', |
| @@ -664,12 +664,12 @@ |
| '../webkit/webkit.gyp:copy_npapi_test_plugin', |
| ], |
| }], |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', |
| ], |
| - }, { # else: OS != "linux" |
| + }, { # else: toolkit_uses_gtk != 1 |
| 'sources!': [ |
| 'browser/process_singleton_linux_uitest.cc', |
| ], |
| @@ -730,7 +730,7 @@ |
| 'browser/printing/printing_layout_uitest.cc', |
| ], |
| }], |
| - ['OS=="linux" or OS=="freebsd"', { |
| + ['os_posix==1 and OS!="mac"', { |
| 'conditions': [ |
| ['linux_use_tcmalloc==1', { |
| 'dependencies': [ |
| @@ -846,7 +846,7 @@ |
| 'test/webdriver/commands/webelement_commands.cc', |
| ], |
| 'conditions': [ |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', |
| @@ -857,7 +857,7 @@ |
| '../views/views.gyp:views', |
| ], |
| }], |
| - ['OS=="linux" or OS=="freebsd"', { |
| + ['os_posix==1 and OS!="mac"', { |
| 'conditions': [ |
| ['linux_use_tcmalloc==1', { |
| 'dependencies': [ |
| @@ -1006,7 +1006,7 @@ |
| ], |
| },], |
| # Set fPIC in case it isn't set. |
| - ['(OS=="linux" or OS=="openbsd" or OS=="freebsd" or OS=="solaris")' |
| + ['os_posix==1 and OS!="mac"' |
| 'and (target_arch=="x64" or target_arch=="arm") and linux_fpic!=1', { |
| 'cflags': ['-fPIC'], |
| },], |
| @@ -1965,7 +1965,7 @@ |
| ['exclude', '^browser/ui/webui/chromeos/login'], |
| ], |
| }], |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'conditions': [ |
| ['selinux==0', { |
| 'dependencies': [ |
| @@ -1995,14 +1995,14 @@ |
| 'sources!': [ |
| 'browser/printing/print_job_unittest.cc', |
| ], |
| - }, { # else: OS != "linux" |
| + }, { # else: toolkit_uses_gtk != 1 |
| 'sources!': [ |
| 'browser/ui/gtk/tabs/tab_renderer_gtk_unittest.cc', |
| 'browser/renderer_host/gtk_key_bindings_handler_unittest.cc', |
| '../views/focus/accelerator_handler_gtk_unittest.cc', |
| ], |
| }], |
| - ['OS=="linux" or OS=="freebsd"', { |
| + ['os_posix==1 and OS!="mac"', { |
| 'conditions': [ |
| ['linux_use_tcmalloc==1', { |
| 'dependencies': [ |
| @@ -2506,7 +2506,7 @@ |
| '../content/browser/child_process_security_policy_browsertest.cc', |
| ], |
| }], |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../build/linux/system.gyp:nss', |
| @@ -2544,7 +2544,7 @@ |
| 'browser/extensions/browser_action_test_util_mac.mm', |
| ], |
| }], |
| - ['OS=="linux" or OS=="freebsd"', { |
| + ['os_posix==1 and OS!="mac"', { |
| 'conditions': [ |
| ['linux_use_tcmalloc==1', { |
| 'dependencies': [ |
| @@ -2677,7 +2677,7 @@ |
| }, |
| }, |
| },], |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', |
| @@ -2708,7 +2708,7 @@ |
| }, |
| }, |
| },], |
| - ['OS=="linux" or OS=="freebsd"', { |
| + ['os_posix==1 and OS!="mac"', { |
| 'conditions': [ |
| ['linux_use_tcmalloc==1', { |
| 'dependencies': [ |
| @@ -2779,7 +2779,7 @@ |
| }, |
| }, |
| },], |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| ], |
| @@ -2816,7 +2816,7 @@ |
| }, |
| }, |
| },], |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', |
| @@ -2854,7 +2854,7 @@ |
| 'test/tab_switching/tab_switching_test.cc', |
| ], |
| 'conditions': [ |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', |
| @@ -2889,7 +2889,7 @@ |
| 'test/memory_test/memory_test.cc', |
| ], |
| 'conditions': [ |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', |
| @@ -3055,7 +3055,7 @@ |
| 'browser/sync/util/data_encryption_unittest.cc', |
| ], |
| }], |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../build/linux/system.gyp:nss', |
| @@ -3179,7 +3179,7 @@ |
| 'test/data/resource.rc', |
| ], |
| 'conditions': [ |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../build/linux/system.gyp:nss', |
| @@ -3327,7 +3327,7 @@ |
| # See comments about "xcode_settings" elsewhere in this file. |
| 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']}, |
| }], |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../build/linux/system.gyp:nss', |
| @@ -3446,7 +3446,7 @@ |
| 'test/perf/url_parse_perftest.cc', |
| ], |
| 'conditions': [ |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
| 'dependencies': [ |
| '../build/linux/system.gyp:gtk', |
| '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', |
| @@ -3602,7 +3602,7 @@ |
| ], # OS=="win" |
| # If you change this condition, make sure you also change it in all.gyp |
| # for the chromium_builder_qa target. |
| - ['OS=="mac" or OS=="win" or (OS=="linux" and target_arch==python_arch)', { |
| + ['OS=="mac" or OS=="win" or (os_posix==1 and target_arch==python_arch)', { |
| 'targets': [ |
| { |
| # Documentation: http://dev.chromium.org/developers/testing/pyauto |
| @@ -3654,7 +3654,7 @@ |
| 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', # -Wno-error |
| }, |
| 'conditions': [ |
| - ['OS=="linux"', { |
| + ['toolkit_uses_gtk==1', { |
|
tony
2011/05/16 19:25:11
This also looks like os_posix==1 and OS!="mac".
|
| 'include_dirs': [ |
| '..', |
| '<(sysroot)/usr/include/python<(python_ver)', |