Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 7011028: Remove unused projects in the official builder target. (Closed)

Created:
9 years, 7 months ago by Nicolas Sylvain
Modified:
9 years, 7 months ago
Reviewers:
kerz_google
CC:
chromium-reviews
Visibility:
Public.

Description

Remove unused projects in the official builder target. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nicolas Sylvain
9 years, 7 months ago (2011-05-13 00:14:38 UTC) #1
kerz_google
9 years, 7 months ago (2011-05-13 00:21:33 UTC) #2
LGTM

On Thu, May 12, 2011 at 5:14 PM, <nsylvain@chromium.org> wrote:

> Reviewers: kerz_google,
>
> Description:
> Remove unused projects in the official builder target.
>
> Please review this at http://codereview.chromium.org/7011028/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     build/all.gyp
>
>
> Index: build/all.gyp
> ===================================================================
> --- build/all.gyp       (revision 85218)
> +++ build/all.gyp       (working copy)
> @@ -497,19 +497,15 @@
>                 '../chrome/app/locales/locales.gyp:*',
>                 '../chrome/chrome.gyp:chromedriver',
>                 '../chrome/chrome.gyp:crash_service',
> -                '../chrome/chrome.gyp:page_cycler_tests',
>                 '../chrome/chrome.gyp:policy_templates',
>                 '../chrome/chrome.gyp:pyautolib',
>                 '../chrome/chrome.gyp:reliability_tests',
> -                '../chrome/chrome.gyp:startup_tests',
>                 '../chrome/chrome.gyp:automated_ui_tests',
>                 '../chrome/installer/mini_installer.gyp:mini_installer',
> -                '../chrome_frame/chrome_frame.gyp:chrome_frame_unittests',
>                 '../chrome_frame/chrome_frame.gyp:npchrome_frame',
>                 '../courgette/courgette.gyp:courgette',
>                 '../courgette/courgette.gyp:courgette64',
>                 '../third_party/adobe/flash/flash_player.gyp:flash_player',
> -                '../webkit/webkit.gyp:test_shell',
>               ],
>               'conditions': [
>                 ['internal_pdf', {
>
>
>

Powered by Google App Engine
This is Rietveld 408576698