Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 7010015: IPC: Increase MAX_DESCRIPTORS_PER_MESSAGE (Closed)

Created:
9 years, 7 months ago by Mark Seaborn
Modified:
9 years, 5 months ago
Reviewers:
agl
CC:
chromium-reviews, pam+watch_chromium.org, Scott Hess - ex-Googler, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

IPC: Increase MAX_DESCRIPTORS_PER_MESSAGE This fixes the loading of Native Client's integrated runtime (IRT) library on Mac, because we need to send 5 descriptors in NaCl's startup IPC message on Mac. I am being conservative in only increasing MAX_DESCRIPTORS_PER_MESSAGE by 1 because it carries a storage cost (in Channel::ChannelImpl::input_cmsg_buf_) which is multiplied by the number of messages that can fit into Channel::kReadBufferSize, and the storage is allocated for the lifetime of the Channel. Note that I am not increasing the size of input_cmsg_buf_ under "#if defined(OS_MACOSX)" in ipc_channel_posix.h because it is already too small in the general case (see http://crbug.com/82829), but NaCl does not exercise this general case. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1804 TEST=NaCl's "run_ppapi_core_browser_test irt=1" when run against Chromium Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ipc/file_descriptor_set_posix.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
9 years, 7 months ago (2011-05-16 22:16:07 UTC) #1
agl
9 years, 7 months ago (2011-05-16 22:25:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698