Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 7008020: Fix up flicker, and parsing by Xcode. (Closed)

Created:
9 years, 7 months ago by dmac
Modified:
9 years, 7 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix up flicker, and parsing by Xcode. The javascript as written had trouble being parsed by the Xcode IDE due to the // in the regexp. By turning off the height:100% in the css, we don't redraw the entire screen every time we update the bandwidth stats. BUG=none TEST=Make a connection and turn on Quartz Debug on Mac. Turn on Flash screen updates. The entire screen should not flash once per second. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M remoting/webapp/me2mom/main.css View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/webapp/me2mom/remoting_session.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dmac
9 years, 7 months ago (2011-05-25 21:56:23 UTC) #1
garykac
9 years, 7 months ago (2011-05-25 22:18:27 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698