Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 7008012: Delete FileAutoDeleter. (Closed)

Created:
9 years, 7 months ago by lain Merrick
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Delete FileAutoDeleter. All existing users were updated to use ScopedTempDir in http://codereview.chromium.org/7056011/. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86805

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M chrome/chrome_tests.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/test/file_test_utils.h View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/test/file_test_utils.cc View 1 2 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lain Merrick
Hi Paweł, here's the last step of replacing FileAutoDeleter with ScopedTempDir, as discussed.
9 years, 7 months ago (2011-05-25 15:09:55 UTC) #1
lain Merrick
On 2011/05/25 15:09:55, Iain Merrick wrote: > Hi Paweł, here's the last step of replacing ...
9 years, 7 months ago (2011-05-25 15:28:29 UTC) #2
Avi (use Gerrit)
I always use the -r <rev> parameter when I do tryjobs. It's great to not ...
9 years, 7 months ago (2011-05-25 15:31:10 UTC) #3
Paweł Hajdan Jr.
LGTM, thanks!
9 years, 7 months ago (2011-05-25 16:03:35 UTC) #4
lain Merrick
9 years, 7 months ago (2011-05-25 16:16:23 UTC) #5
On 2011/05/25 15:31:10, Avi wrote:
> I always use the -r <rev> parameter when I do tryjobs. It's great to not
> have to think about LKGR.

Aha, makes sense. Thanks for the tip!

Powered by Google App Engine
This is Rietveld 408576698