Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 7008011: First step in refactoring hydrogen control instructions. (Closed)

Created:
9 years, 7 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

First step in refactoring hydrogen control instructions. This change changes the internal data structure of HControlInstruction and introduced an iterator interface to enumerate all successors of a block. It also saves allocation space by only allocating so many successor blocks as needed for each instruction. Next step is to allow HControlInstructions with >2 successors.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -70 lines) Patch
M src/hydrogen.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 2 5 chunks +22 lines, -21 lines 0 comments Download
M src/hydrogen-instructions.h View 1 7 chunks +60 lines, -37 lines 1 comment Download
M src/lithium-allocator.cc View 1 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
9 years, 7 months ago (2011-05-25 10:52:01 UTC) #1
fschneider
Added iterator interface + refactored code to use it.
9 years, 7 months ago (2011-05-25 12:35:40 UTC) #2
Kevin Millikin (Chromium)
9 years, 7 months ago (2011-05-25 15:50:28 UTC) #3
Quick comment, I'll look more closely later.

http://codereview.chromium.org/7008011/diff/5001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/7008011/diff/5001/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:793: template<typename T, int NumElements>
We have more or less this class "OperandContainer" in the lithium-xxx.h files,
and we also have "HOperandContainer" which is just specialized to HValue*.

You should just add an EmbeddedContainer class to utils.h, I think.

Powered by Google App Engine
This is Rietveld 408576698