chrome/browser/ui/views/download/download_item_view.cc - Issue 7008005: base/i18n: Pass |str| as const reference in BreakIterator::Init().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_item_view.cc

Issue 7008005: base/i18n: Pass |str| as const reference in BreakIterator::Init(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync to ToT Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/download/download_item_view.cc

diff --git a/chrome/browser/ui/views/download/download_item_view.cc b/chrome/browser/ui/views/download/download_item_view.cc

index a90976622a94f063ee89b5b5ee12940f66030159..c94f0e5f39b48811af679c6f20fd671337ce831c 100644

--- a/chrome/browser/ui/views/download/download_item_view.cc

+++ b/chrome/browser/ui/views/download/download_item_view.cc

@@ -1043,7 +1043,7 @@ void DownloadItemView::SizeLabelToMinWidth() {

// Using BREAK_WORD can work in most cases, but it can also break

// lines where it should not. Using BREAK_LINE is safer although

// slower for Chinese/Japanese. This is not perf-critical at all, though.

- base::i18n::BreakIterator iter(&text, base::i18n::BreakIterator::BREAK_LINE);

+ base::i18n::BreakIterator iter(text, base::i18n::BreakIterator::BREAK_LINE);

bool status = iter.Init();

DCHECK(status);