Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 7008004: Add a histogram for the number of hostname patterns for content settings (Closed)

Created:
9 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add a histogram for the number of hostname patterns for content settings BUG=83825 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86641

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/content_settings/content_settings_pref_provider.cc View 1 2 chunks +6 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
please review
9 years, 7 months ago (2011-05-25 01:04:23 UTC) #1
jar (doing other things)
LGTM (with the caveat below) http://codereview.chromium.org/7008004/diff/3001/chrome/browser/content_settings/content_settings_pref_provider.cc File chrome/browser/content_settings/content_settings_pref_provider.cc (right): http://codereview.chromium.org/7008004/diff/3001/chrome/browser/content_settings/content_settings_pref_provider.cc#newcode377 chrome/browser/content_settings/content_settings_pref_provider.cc:377: UMA_HISTOGRAM_COUNTS("ContentSettings.NumberOfExceptions", One thing to ...
9 years, 7 months ago (2011-05-25 02:19:50 UTC) #2
jochen (gone - plz use gerrit)
On 2011/05/25 02:19:50, jar wrote: > LGTM (with the caveat below) > > http://codereview.chromium.org/7008004/diff/3001/chrome/browser/content_settings/content_settings_pref_provider.cc > ...
9 years, 7 months ago (2011-05-25 15:08:23 UTC) #3
commit-bot: I haz the power
9 years, 7 months ago (2011-05-25 16:44:54 UTC) #4
Change committed as 86641

Powered by Google App Engine
This is Rietveld 408576698