Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 7006031: Reapply r922 with the dependencies reversed. (Closed)

Created:
9 years, 6 months ago by Evan Martin
Modified:
9 years, 6 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Reapply r922 with the dependencies reversed. r922 made sure that the flattened set of dependencies for a given target were themselves in pre-flattening dependency order. It regressed build performance. As an experiment to help judge why, reapply r922 with the list reversed. Committed: http://code.google.com/p/gyp/source/detail?r=932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M pylib/gyp/input.py View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
I intend to land this, update Chrome, see how the buildbots react, and then either ...
9 years, 6 months ago (2011-06-03 16:30:54 UTC) #1
Mark Mentovai
LGTM for experimentation. Don’t leave this as-is for too long.
9 years, 6 months ago (2011-06-03 16:42:25 UTC) #2
Yuki Shiino
9 years, 6 months ago (2011-06-03 18:28:17 UTC) #3
LGTM, too.

Thanks for taking care of this issue.

Powered by Google App Engine
This is Rietveld 408576698