chrome/browser/geolocation/geolocation_permission_context_unittest.cc - Issue 7006010: Change InfoBar-related notifications to be sourced from a TabContentsWrapper, not a TabContents. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Issue 7006010: Change InfoBar-related notifications to be sourced from a TabContentsWrapper, not a TabContents. ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_browsertest.cc ('k') | chrome/browser/tab_contents/infobar.h » ('j') | chrome/browser/tab_contents/infobar.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

===================================================================

--- chrome/browser/geolocation/geolocation_permission_context_unittest.cc (revision 87366)

+++ chrome/browser/geolocation/geolocation_permission_context_unittest.cc (working copy)

@@ -51,7 +51,7 @@

: TabContentsWrapper(

new TabContents(profile, instance, MSG_ROUTING_NONE, NULL, NULL)),

removed_infobar_delegate_(NULL) {

- Source<TabContents> source(tab_contents());

+ Source<TabContentsWrapper> source(this);

registrar_.Add(this, NotificationType::TAB_CONTENTS_INFOBAR_REMOVED,

source);

}

@@ -63,10 +63,12 @@

NotificationType type,

const NotificationSource& source,

const NotificationDetails& details) {

- if (type.value == NotificationType::TAB_CONTENTS_INFOBAR_REMOVED)

- removed_infobar_delegate_ = Details<InfoBarDelegate>(details).ptr();

- else

+ if (type.value == NotificationType::TAB_CONTENTS_INFOBAR_REMOVED) {

+ removed_infobar_delegate_ =

+ Details<std::pair<InfoBarDelegate*, bool> >(details)->first;

+ } else {

TabContentsWrapper::Observe(type, source, details);

+ }

}

} // namespace

« no previous file with comments | « chrome/browser/geolocation/geolocation_browsertest.cc ('k') | chrome/browser/tab_contents/infobar.h » ('j') | chrome/browser/tab_contents/infobar.h » ('J')