chrome/browser/translate/translate_manager_browsertest.cc - Issue 7006010: Change InfoBar-related notifications to be sourced from a TabContentsWrapper, not a TabContents. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager_browsertest.cc

Issue 7006010: Change InfoBar-related notifications to be sourced from a TabContentsWrapper, not a TabContents. ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tab_contents/tab_contents_ssl_helper.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_infobar_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_manager_browsertest.cc

===================================================================

--- chrome/browser/translate/translate_manager_browsertest.cc (revision 87541)

+++ chrome/browser/translate/translate_manager_browsertest.cc (working copy)

@@ -138,7 +138,8 @@

const NotificationSource& source,

const NotificationDetails& details) {

DCHECK_EQ(NotificationType::TAB_CONTENTS_INFOBAR_REMOVED, type.value);

- removed_infobars_.insert(Details<InfoBarDelegate>(details).ptr());

+ removed_infobars_.insert(

+ Details<std::pair<InfoBarDelegate*, bool> >(details)->first);

}

protected:

@@ -161,7 +162,7 @@

notification_registrar_.Add(this,

NotificationType::TAB_CONTENTS_INFOBAR_REMOVED,

- Source<TabContents>(contents()));

+ Source<TabContentsWrapper>(contents_wrapper()));

}

virtual void TearDown() {

@@ -169,7 +170,7 @@

notification_registrar_.Remove(this,

NotificationType::TAB_CONTENTS_INFOBAR_REMOVED,

- Source<TabContents>(contents()));

+ Source<TabContentsWrapper>(contents_wrapper()));

TabContentsWrapperTestHarness::TearDown();