chrome/browser/automation/automation_provider_observers.cc - Issue 7006010: Change InfoBar-related notifications to be sourced from a TabContentsWrapper, not a TabContents. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_provider_observers.cc

Issue 7006010: Change InfoBar-related notifications to be sourced from a TabContentsWrapper, not a TabContents. ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/automation_provider_observers.h ('k') | chrome/browser/automation/testing_automation_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/automation_provider_observers.cc

===================================================================

--- chrome/browser/automation/automation_provider_observers.cc (revision 87541)

+++ chrome/browser/automation/automation_provider_observers.cc (working copy)

@@ -1363,13 +1363,13 @@

InfoBarCountObserver::InfoBarCountObserver(AutomationProvider* automation,

IPC::Message* reply_message,

- TabContents* tab_contents,

+ TabContentsWrapper* tab_contents,

size_t target_count)

: automation_(automation->AsWeakPtr()),

reply_message_(reply_message),

tab_contents_(tab_contents),

target_count_(target_count) {

- Source<TabContents> source(tab_contents);

+ Source<TabContentsWrapper> source(tab_contents);

registrar_.Add(this, NotificationType::TAB_CONTENTS_INFOBAR_ADDED, source);

registrar_.Add(this, NotificationType::TAB_CONTENTS_INFOBAR_REMOVED, source);

CheckCount();

@@ -1386,9 +1386,7 @@

}

void InfoBarCountObserver::CheckCount() {

- TabContentsWrapper* wrapper =

- TabContentsWrapper::GetCurrentWrapperForContents(tab_contents_);

- if (wrapper->infobar_count() != target_count_)

+ if (tab_contents_->infobar_count() != target_count_)

return;

if (automation_) {