chrome/browser/ui/gtk/tab_contents_drag_source.cc - Issue 7005011: Fix bug 79905: Drag and drop of "DownloadURL" type ignores specified filename for data URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/tab_contents_drag_source.cc

Issue 7005011: Fix bug 79905: Drag and drop of "DownloadURL" type ignores specified filename for data URLs. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/web_drag_source.mm ('k') | chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/tab_contents_drag_source.cc

===================================================================

--- chrome/browser/ui/gtk/tab_contents_drag_source.cc (revision 85826)

+++ chrome/browser/ui/gtk/tab_contents_drag_source.cc (working copy)

@@ -291,15 +291,12 @@

GdkDragContext* drag_context) {

if (!download_url_.is_empty()) {

// Generate the file name based on both mime type and proposed file name.

- std::string download_mime_type = UTF16ToUTF8(wide_download_mime_type_);

- std::string content_disposition("attachment; filename=");

- content_disposition += download_file_name_.value();

FilePath generated_download_file_name;

- download_util::GenerateFileName(download_url_,

- content_disposition,

- std::string(),

- download_mime_type,

- &generated_download_file_name);

+ download_util::GenerateFileNameFromSuggestedName(

+ download_url_,

+ download_file_name_.value(),

+ UTF16ToUTF8(wide_download_mime_type_),

+ &generated_download_file_name);

// Pass the file name to the drop target by setting the source window's

// XdndDirectSave0 property.