Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/pyautolib/pyauto.py

Issue 7005007: Add an alternative way to specify extra chrome flags via env for testing (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/proxy_launcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/pyautolib/pyauto.py
===================================================================
--- chrome/test/pyautolib/pyauto.py (revision 84824)
+++ chrome/test/pyautolib/pyauto.py (working copy)
@@ -3511,12 +3511,7 @@
chrome_flags = self._options.chrome_flags
# Set CHROME_HEADLESS. It enables crash reporter on posix.
os.putenv('CHROME_HEADLESS', '1')
- # --dom-automation added in PyUITestBase::PyUITestBase()
-
- suite_args.append('--extra-chrome-flags=%s' % chrome_flags)
- # Note: The suite_args passed here are ignored on windows since it
- # overrides to obtain the command line for the current process directly.
- # Refer CommandLine::Init().
+ os.putenv('EXTRA_CHROME_FLAGS', chrome_flags)
pyauto_suite = PyUITestSuite(suite_args)
test_names = self._ExpandTestNames(self._args)
test_names *= self._options.repeat
« no previous file with comments | « chrome/test/automation/proxy_launcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698