Add an alternative way to specify extra chrome flags via env for testing

Add an alternative way to specify extra chrome flags via env for testing

This is to work around a problem where passed command line flags (thru pyauto flag --chrome-flags) will not take effect on win.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84939

[dtu, 2011-05-11 00:03:32]

LGTM

[Paweł Hajdan Jr., 2011-05-11 07:07:14]

Some automation comments (please note you're required to get OWNERS approval for
chrome/test changes).

It seems that the extra flags logic is only used by pyauto. Could you switch all
users to the env variable, and remove the extra-chrome-flags command-line option
completely?

[Nirnimesh, 2011-05-11 07:12:00]

On 2011/05/11 07:07:14, Paweł Hajdan Jr. wrote:
> Some automation comments (please note you're required to get OWNERS approval
for
> chrome/test changes).

Weird that the presubmit checks did not remind me.

> 
> It seems that the extra flags logic is only used by pyauto. Could you switch
all
> users to the env variable, and remove the extra-chrome-flags command-line
option
> completely?

--extra-chrome-flags is more handy for all test binaries.
This is just an alternative. If I could, I'd use the command line approach
completely for pyauto tests, but can't on win.

[Paweł Hajdan Jr., 2011-05-11 07:20:21]

On 2011/05/11 07:12:00, Nirnimesh wrote:
> On 2011/05/11 07:07:14, Paweł Hajdan Jr. wrote:
> > Some automation comments (please note you're required to get OWNERS approval
> for
> > chrome/test changes).
> 
> Weird that the presubmit checks did not remind me.

No worries, I'm watching anyway. ;-) The change could reasonably be considered
simple.

> > It seems that the extra flags logic is only used by pyauto. Could you switch
> all
> > users to the env variable, and remove the extra-chrome-flags command-line
> option
> > completely?
> 
> --extra-chrome-flags is more handy for all test binaries.
> This is just an alternative. If I could, I'd use the command line approach
> completely for pyauto tests, but can't on win.

Right, but is there now anything that still uses extra-chrome-flags? If any, it
seems it would be at most 1-2 places. I think it's generally better to remove
redundant mechanisms for the same thing, for maintainability. It's really a
minor issue, I'd just like to keep the ProxyLauncher very clean.

[Nirnimesh, 2011-05-11 07:27:01]

> Right, but is there now anything that still uses extra-chrome-flags? If any,
it
> seems it would be at most 1-2 places. I think it's generally better to remove
> redundant mechanisms for the same thing, for maintainability. It's really a
> minor issue, I'd just like to keep the ProxyLauncher very clean.

I know that people use --extra-chrome-flags with the C++ test binaries, while
debugging something when running it by hand.

[Paweł Hajdan Jr., 2011-05-11 07:50:44]

On 2011/05/11 07:27:01, Nirnimesh wrote:
> > Right, but is there now anything that still uses extra-chrome-flags? If any,
> it
> > seems it would be at most 1-2 places. I think it's generally better to
remove
> > redundant mechanisms for the same thing, for maintainability. It's really a
> > minor issue, I'd just like to keep the ProxyLauncher very clean.
> 
> I know that people use --extra-chrome-flags with the C++ test binaries, while
> debugging something when running it by hand.

It should be equally easy to use EXTRA_CHROME_FLAGS="...", at least on Linux and
Mac. Is it harder to pass env vars on Windows? If there are no major issues, I'd
really like to pick just one way to pass extra switches to Chrome and use that.