Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 7004051: Some internal methods are requested when v8 is built as DLL (V8_SHARED), and (Closed)

Created:
9 years, 7 months ago by Nebojša Ćirić
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Some internal methods are requested when v8 is built as DLL (V8_SHARED), and they are not available. Make them no-op (or better yet part of public API). TEST = Build Chromium with V8_SHARED

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/extensions/experimental/i18n-extension.cc View 1 chunk +9 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Nebojša Ćirić
One option is to do what I uploaded here (make no-op of internal method). Other ...
9 years, 7 months ago (2011-05-20 22:48:07 UTC) #1
Mads Ager (chromium)
9 years, 7 months ago (2011-05-23 06:13:30 UTC) #2
LGTM as a stop gap solution to be able to push V8 to chromium without breaking
the build.

http://codereview.chromium.org/7004051/diff/1/src/extensions/experimental/i18...
File src/extensions/experimental/i18n-extension.cc (right):

http://codereview.chromium.org/7004051/diff/1/src/extensions/experimental/i18...
src/extensions/experimental/i18n-extension.cc:86: void
Malloced::FatalProcessOutOfMemory() {
Why does this extension which is not a part of V8 as such depend on
allocation.h? It shouldn't. We should not expose this method through the API and
defining it here makes little sense. Let's clean up the dependencies instead. I
don't see why this extension would need anything not in the public API.

I will land this change as a stop gap solution so I can push V8 to Chromium (I
just created a version so I will have to do a patch release).

Please make sure to test the shared library build for every change to this
extension so this does not happen again.

Powered by Google App Engine
This is Rietveld 408576698