Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 7004050: [ChromeOS] Enable hovering effect for "not configured" network. (Closed)

Created:
9 years, 7 months ago by xiyuan
Modified:
9 years, 7 months ago
Reviewers:
Charlie Lee
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[ChromeOS] Enable hovering effect for "not configured" network. Also fixed a "connecting" attribute not properly set problem. BUG=chromium-os:15596 TEST=Verify fix for chromium-ls:15596. i.e. Blue strip shows up on hovering "not configured" networks. Also "connecting" network now will show up in a lighter blue (compared with "connected" networks) box with no hovering and no buttons. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86293

Patch Set 1 #

Patch Set 2 : updates after discussion with chocobo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M chrome/browser/resources/options/chromeos/internet_network_element.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/internet_options_page.css View 1 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
9 years, 7 months ago (2011-05-20 22:42:27 UTC) #1
Charlie Lee
LGTM
9 years, 7 months ago (2011-05-20 22:46:23 UTC) #2
xiyuan
Thanks for pointing out that we need to handle "connecting" networks. CL updated: - Fixed ...
9 years, 7 months ago (2011-05-20 23:20:10 UTC) #3
Charlie Lee
9 years, 7 months ago (2011-05-21 00:12:46 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698