Issue 7004046: Fix use of SupportAccessVerifier in Host plugin.

Issue 7004046: Fix use of SupportAccessVerifier in Host plugin. (Closed)

Created:
9 years, 7 months ago by Wez

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix use of SupportAccessVerifier in Host plugin. BUG= TEST=Host plugin accepts connection if Access Code supplied to Viewer is valid. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86170

Patch Set 1 #

Total comments: 4

Patch Set 2 : Pick nits. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -16 lines)			Patch
	M	remoting/host/host_plugin.cc	View	1	6 chunks	+23 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Wez

Use the SupportAccessVerifier correctly, so that authentication succeeds. (This only fixes authentication; the Host will ...

9 years, 7 months ago (2011-05-20 20:10:41 UTC) #1

Jamie

http://codereview.chromium.org/7004046/diff/1/remoting/host/host_plugin.cc File remoting/host/host_plugin.cc (right): http://codereview.chromium.org/7004046/diff/1/remoting/host/host_plugin.cc#newcode314 remoting/host/host_plugin.cc:314: std::string host_secret_; Is this still needed now that the ...

9 years, 7 months ago (2011-05-20 20:18:02 UTC) #2

Wez

PTAL! http://codereview.chromium.org/7004046/diff/1/remoting/host/host_plugin.cc File remoting/host/host_plugin.cc (right): http://codereview.chromium.org/7004046/diff/1/remoting/host/host_plugin.cc#newcode314 remoting/host/host_plugin.cc:314: std::string host_secret_; On 2011/05/20 20:18:02, Jamie wrote: > ...

9 years, 7 months ago (2011-05-20 20:52:09 UTC) #3

Change committed as 86170

Expand Messages | Collapse Messages