Issue 7004042: Fix Wrong Offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7004042: Fix Wrong Offset (Closed)

Created:
9 years, 7 months ago by mrossetti

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix Wrong Offset Set content offset using fill_into_edit's length and not the length of the originally typed term. BUG=82994 TEST=Added unit test. Manual test: 1) Delete the 'History Provider Cache' file, 2) Start Chrome, 3) Type 'about:flags' into omnibox and <ret>, 4) Type 'about:flags/' or 'about:flags@' into omnibox. There should no longer be an assert at this point. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86171

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	chrome/browser/autocomplete/history_quick_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/autocomplete/history_quick_provider_unittest.cc	View		1 chunk	+8 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/7004042/diff/1/chrome/browser/autocomplete/history_quick_provider_unittest.cc File chrome/browser/autocomplete/history_quick_provider_unittest.cc (right): http://codereview.chromium.org/7004042/diff/1/chrome/browser/autocomplete/history_quick_provider_unittest.cc#newcode227 chrome/browser/autocomplete/history_quick_provider_unittest.cc:227: std::string expected_url("http://slashdot.org/favorite_page.html"); Remind me why this catches the ...

9 years, 7 months ago (2011-05-20 22:06:41 UTC) #2

mrossetti

9 years, 7 months ago (2011-05-20 23:26:13 UTC) #4

On 2011/05/20 22:06:41, Peter Kasting wrote:
> LGTM
> 
>
http://codereview.chromium.org/7004042/diff/1/chrome/browser/autocomplete/his...
> File chrome/browser/autocomplete/history_quick_provider_unittest.cc (right):
> 
>
http://codereview.chromium.org/7004042/diff/1/chrome/browser/autocomplete/his...
> chrome/browser/autocomplete/history_quick_provider_unittest.cc:227:
std::string
> expected_url("http://slashdot.org/favorite_page.html");
> Remind me why this catches the bug?

It would, under the old code, trigger the DCHECK_LE because of the trailing '/'
in the query string.

Expand Messages | Collapse Messages