Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 7004039: Cancel downloads earlier when prerendering. (Closed)

Created:
9 years, 7 months ago by mmenke
Modified:
9 years, 7 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Cancel downloads earlier when prerendering. Downloads while prerendering should no longer create history items, and this should fix the flake in the prerendering download tests. BUG=81798, 81985 TEST=PrerenderBrowserTest.PrerenderDownloadLocation and several others. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86134

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove outdated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 7 chunks +4 lines, -21 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 7 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mmenke
Sorry for sending all my reviews your way, but with Chris out for the week, ...
9 years, 7 months ago (2011-05-20 17:37:44 UTC) #1
dominich
LGTM http://codereview.chromium.org/7004039/diff/1/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): http://codereview.chromium.org/7004039/diff/1/chrome/browser/prerender/prerender_browsertest.cc#newcode244 chrome/browser/prerender/prerender_browsertest.cc:244: // TODO(mmenke): Once downloading is stopped earlier, remove ...
9 years, 7 months ago (2011-05-20 17:42:35 UTC) #2
mmenke
Thanks for the review. http://codereview.chromium.org/7004039/diff/1/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): http://codereview.chromium.org/7004039/diff/1/chrome/browser/prerender/prerender_browsertest.cc#newcode244 chrome/browser/prerender/prerender_browsertest.cc:244: // TODO(mmenke): Once downloading is ...
9 years, 7 months ago (2011-05-20 17:45:12 UTC) #3
commit-bot: I haz the power
9 years, 7 months ago (2011-05-20 20:04:59 UTC) #4
Change committed as 86134

Powered by Google App Engine
This is Rietveld 408576698