Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2620)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm

Issue 7004036: Added some enhancements to OCMock. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm
index 70db47bd2d14bbcd99a85d2072dee15e640a12ea..915cf964d250d09d4bb9b7b80cc0e112ca6f5e58 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm
@@ -13,6 +13,7 @@
#include "testing/platform_test.h"
#include "third_party/ocmock/gtest_support.h"
#import "third_party/ocmock/OCMock/OCMock.h"
+#include "third_party/ocmock/ocmock_extensions.h"
@interface OCMockObject(PreventRetainCycle)
- (void)clearRecordersAndExpectations;
@@ -50,7 +51,7 @@ class BookmarkFolderTargetTest : public CocoaTest {
TEST_F(BookmarkFolderTargetTest, StartWithNothing) {
// Need a fake "button" which has a bookmark node.
id sender = [OCMockObject mockForClass:[BookmarkButton class]];
- [[[sender stub] andReturnValue:OCMOCK_VALUE(bmbNode_)] bookmarkNode];
+ [[[sender stub] andReturnPointer:bmbNode_] bookmarkNode];
// Fake controller
id controller = [OCMockObject mockForClass:[BookmarkBarFolderController
@@ -71,7 +72,7 @@ TEST_F(BookmarkFolderTargetTest, StartWithNothing) {
TEST_F(BookmarkFolderTargetTest, ReopenSameFolder) {
// Need a fake "button" which has a bookmark node.
id sender = [OCMockObject mockForClass:[BookmarkButton class]];
- [[[sender stub] andReturnValue:OCMOCK_VALUE(bmbNode_)] bookmarkNode];
+ [[[sender stub] andReturnPointer:bmbNode_] bookmarkNode];
// Fake controller
id controller = [OCMockObject mockForClass:[BookmarkBarFolderController
@@ -102,7 +103,7 @@ TEST_F(BookmarkFolderTargetTest, ReopenSameFolder) {
TEST_F(BookmarkFolderTargetTest, ReopenNotSame) {
// Need a fake "button" which has a bookmark node.
id sender = [OCMockObject mockForClass:[BookmarkButton class]];
- [[[sender stub] andReturnValue:OCMOCK_VALUE(bmbNode_)] bookmarkNode];
+ [[[sender stub] andReturnPointer:bmbNode_] bookmarkNode];
// Fake controller
id controller = [OCMockObject mockForClass:[BookmarkBarFolderController

Powered by Google App Engine
This is Rietveld 408576698