Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7004036: Added some enhancements to OCMock. (Closed)

Created:
9 years, 7 months ago by dmac
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Added some enhancements to OCMock. BUG=NONE TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86474

Patch Set 1 #

Total comments: 5

Patch Set 2 : removed pointer because it doesn't actually work #

Patch Set 3 : cleaned up tvl's complaints #

Patch Set 4 : fixed up protocol stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -13 lines) Patch
M chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm View 4 chunks +3 lines, -5 lines 0 comments Download
M third_party/ocmock/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/ocmock/ocmock.gyp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/ocmock/ocmock_extensions.h View 1 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/ocmock/ocmock_extensions.mm View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dmac
PTAL sir?
9 years, 7 months ago (2011-05-20 15:58:39 UTC) #1
TVL
lgtm http://codereview.chromium.org/7004036/diff/1/chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm File chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm (right): http://codereview.chromium.org/7004036/diff/1/chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm#newcode65 chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm:65: [[[delegate stub] andReturnValue:OCMOCK_VALUE(yes)] did you want to replace ...
9 years, 7 months ago (2011-05-20 16:07:04 UTC) #2
commit-bot: I haz the power
Try job failure for 7004036-1009 on mac: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=28121
9 years, 7 months ago (2011-05-20 18:25:57 UTC) #3
commit-bot: I haz the power
Try job failure for 7004036-1009 on mac: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=28169
9 years, 7 months ago (2011-05-20 21:41:34 UTC) #4
commit-bot: I haz the power
Try job failure for 7004036-1009 on mac: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=28359
9 years, 7 months ago (2011-05-23 17:05:18 UTC) #5
commit-bot: I haz the power
Try job failure for 7004036-8001 on linux: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&number=28034
9 years, 7 months ago (2011-05-23 19:06:50 UTC) #6
commit-bot: I haz the power
9 years, 7 months ago (2011-05-24 19:57:45 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698