Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 7004033: This CL splits out the testing subpart of utman.sh into a separate script (Closed)

Created:
9 years, 7 months ago by robertm
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

This CL splits out the testing subpart of utman.sh into a separate testing script: utman-test.sh There is essentially no coupling between testing and the rest of the utman script so this will reduce the size of the massive utman.sh by 10% without much surgery. Going forward this separation allows us to unify utman-test.sh with the build bot scripts buildbot/buildbot_pnacl1.sh and buildbot/buildbot_pnacl2.sh. This should help eliminate code duplication and ensure that we run the same tests for local pnacl toolchain builds and on the bots. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1647 Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3170 lines) Patch
M tools/llvm/utman.sh View 1 chunk +0 lines, -250 lines 0 comments Download
A + tools/llvm/utman-test.sh View 4 chunks +8 lines, -2920 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertm
PTAL
9 years, 7 months ago (2011-05-20 15:37:42 UTC) #1
(google.com) Derek Schuff
LGTM
9 years, 7 months ago (2011-05-20 15:48:28 UTC) #2
jvoung - send to chromium...
9 years, 7 months ago (2011-05-20 16:46:31 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698