Fix to make InputMethodIBus usable on every ChromeOS device (even without TouchUI)

Fix to make InputMethodIBus usable on every ChromeOS device (even without TouchUI)

Add switch "--enable-inputmethod-ibus" to enable InputMethodIBus on ChromeOS
Modify gyp files to link IBus

BUG=chromium-os:15566
TEST=manually

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86390

[hashimoto, 2011-05-20 03:08:18]

small changes on InputMethodIBus to add switch
small changes on gyp files to enable IBus
small change on NativeWidgetGtk to enable InputMethodIBus

[oshima, 2011-05-20 21:47:31]

http://codereview.chromium.org/7004029/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7004029/diff/1/build/common.gypi#newcode568
build/common.gypi:568: ['chromeos==1', {
please keep touchui=1. If one wants to use ibus on chromeos, he/she can set this
manually.

http://codereview.chromium.org/7004029/diff/1/views/ime/input_method_ibus.h
File views/ime/input_method_ibus.h (right):

http://codereview.chromium.org/7004029/diff/1/views/ime/input_method_ibus.h#n...
views/ime/input_method_ibus.h:45: // 1) built with GYP_DEFINES="touchui=1"
please add " or,"  at the end. same for the rest.

http://codereview.chromium.org/7004029/diff/1/views/widget/native_widget_gtk.cc
File views/widget/native_widget_gtk.cc (right):

http://codereview.chromium.org/7004029/diff/1/views/widget/native_widget_gtk....
views/widget/native_widget_gtk.cc:48: #if defined(HAVE_IBUS)
this change adds gtk impl to touch. could you please change so that
touch won't compile  & link gtk?

[hashimoto, 2011-05-20 22:18:13]

http://codereview.chromium.org/7004029/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7004029/diff/1/build/common.gypi#newcode568
build/common.gypi:568: ['chromeos==1', {
What 'use_ibus=1' does is simply adding IBus to dependencies and defining
HAVE_IBUS.
Unless TOUCH_UI is defined or --enable-inputmethod-ibus flag is set, IBus is not
used even when 'use_ibus==1'.

[oshima, 2011-05-20 23:05:15]

On Fri, May 20, 2011 at 3:18 PM, <hashimoto@chromium.org> wrote:

>
> http://codereview.chromium.org/7004029/diff/1/build/common.gypi
> File build/common.gypi (right):
>
> http://codereview.chromium.org/7004029/diff/1/build/common.gypi#newcode568
> build/common.gypi:568: ['chromeos==1', {
> What 'use_ibus=1' does is simply adding IBus to dependencies and
> defining HAVE_IBUS.
> Unless TOUCH_UI is defined or --enable-inputmethod-ibus flag is set,
> IBus is not used even when 'use_ibus==1'.


This may cause issue to those who are building chrome outside of
chroot. Will this build fine outside of chroot?


>
>
> http://codereview.chromium.org/7004029/
>

[hashimoto, 2011-05-20 23:19:47]

As you say, it causes problem outside chroot.
Keeping touchui==1 seems good.

[oshima, 2011-05-22 01:18:56]

http://codereview.chromium.org/7004029/diff/3005/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7004029/diff/3005/build/common.gypi#newcode567
build/common.gypi:567: # Set 1 to enable ibus support.
Set use_ibus to 1 to enable ...

http://codereview.chromium.org/7004029/diff/3005/views/widget/native_widget_g...
File views/widget/native_widget_gtk.cc (right):

http://codereview.chromium.org/7004029/diff/3005/views/widget/native_widget_g...
views/widget/native_widget_gtk.cc:627: }
} else {

http://codereview.chromium.org/7004029/diff/3005/views/widget/native_widget_g...
views/widget/native_widget_gtk.cc:629: input_method_.reset(new
InputMethodGtk(this));
won't this causes link error in touch build? (since you excluded gtk for touch)

[hashimoto, 2011-05-23 07:34:24]

Sorry for my carelessness.
I fixed these problems and checked that the builds for "touchui=1" and
"use_ibus=0" success.

[hashimoto, 2011-05-23 17:43:11]

Inserted one single space between "if" and "{"

[oshima, 2011-05-23 20:27:19]

LGTM with nits

http://codereview.chromium.org/7004029/diff/15001/views/widget/native_widget_...
File views/widget/native_widget_gtk.cc (right):

http://codereview.chromium.org/7004029/diff/15001/views/widget/native_widget_...
views/widget/native_widget_gtk.cc:631: }
nit: nuke {}