Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 7004011: Nits fix on trace_event.h and child_trace_message_filter.cc (Closed)

Created:
9 years, 7 months ago by scheib
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Nits fix on trace_event.h and child_trace_message_filter.cc BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M base/debug/trace_event.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/child_trace_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
No reviewers yet.
9 years, 7 months ago (2011-05-10 23:37:10 UTC) #1
scheib
9 years, 7 months ago (2011-05-10 23:37:12 UTC) #2
scheib
9 years, 7 months ago (2011-05-10 23:37:44 UTC) #3
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 7 months ago (2011-05-10 23:38:09 UTC) #4
jbates
lgtm
9 years, 7 months ago (2011-05-10 23:39:46 UTC) #5
commit-bot: I haz the power
9 years, 7 months ago (2011-05-10 23:45:16 UTC) #6
Presubmit check for 7004011-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
base/debug/trace_event.h,content/common/child_trace_message_filter.cc

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698