Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7004007: iwyu: Include stringprintf.h where appropriate, part 2. (Closed)

Created:
9 years, 7 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
csilv, Nico
CC:
chromium-reviews, GeorgeY, cbentzel+watch_chromium.org, idana, Raghu Simha, Erik does not do reviews, Paweł Hajdan Jr., kkania, ncarter (slow), Aaron Boodman, darin-cc_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org, estade+watch_chromium.org, Ilya Sherman, tim (not reviewing), dhollowa
Visibility:
Public.

Description

iwyu: Include stringprintf.h where appropriate, part 2. BUG=82098 TEST=none R=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85048

Patch Set 1 #

Patch Set 2 : Compile fix. #

Patch Set 3 : Fix 2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -157 lines) Patch
M chrome/app/chrome_main.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/autofill/form_structure.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/phone_number_i18n.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_main.cc View 4 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/history/history_unittest_base.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/history/text_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/importer/nss_decryptor_system_nss.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/importer/profile_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/net/load_timing_observer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/passive_log_collector_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_request_slow_download_job.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc View 2 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/process_singleton_linux.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_parser.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_parser_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 6 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/gpu_internals_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_common.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/external_extension_uitest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.cc View 2 chunks +17 lines, -10 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/service/net/service_url_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/javascript_message_utils.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/test/ui/ui_layout_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/unit/chrome_test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/tools/convert_dict/aff_reader.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome_frame/chrome_launcher_utils.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
9 years, 7 months ago (2011-05-10 20:33:25 UTC) #1
James Hawkins
Ping. This should be ready for review now, compile-wise.
9 years, 7 months ago (2011-05-11 19:04:37 UTC) #2
James Hawkins
Chris, can you take a look? It's pretty trivial. Nico is at IO and the ...
9 years, 7 months ago (2011-05-11 20:50:03 UTC) #3
csilv
9 years, 7 months ago (2011-05-11 21:27:08 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698