Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 7004005: Reland r84802 with a fix - Disable ICF for Valgrind/ThreadSanitizer Release builds (Closed)

Created:
9 years, 7 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews
Visibility:
Public.

Description

Reland r84802 with a fix - Disable ICF for Valgrind/ThreadSanitizer Release builds With ICF the linker merges identical functions into one block of assembly, which leads to a) wrong symbols for some functions - which is debugger/Valgrind-unfriendly b) all ThreadSanitizer annotations end up being one function which makes TSan crazy. Since we run release code (with -O1 -g) on Valgrind bots, we have to disable ICF if release_valgrind_build!=0. BUG=82114 TEST=linux_tsan trybot goes green TEST=`gclient runhooks` with and w/o GYP_DEFINES="release_valgrind_build=1" and `grep "\-\-icf" base/base.target.mk` Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/common.gypi View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
9 years, 7 months ago (2011-05-10 19:09:45 UTC) #1
bradn
9 years, 7 months ago (2011-05-10 19:45:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698