Print Preview: Refactoring/Cleaning up print_preview.js.

Print Preview: Refactoring/Cleaning up print_preview.js.

Moving several functions to print_preview_utils.js. Also modifying signatures
of these functions so that they dont depend on print_preview.js. This helps in
testing those functions and it is much cleaner.

BUG=NONE
TEST=Behavior of print preview should be unchanged.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88938

[Lei Zhang, 2011-06-13 20:51:51]

LGTM with nits

http://codereview.chromium.org/7003153/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview_utils.js (right):

http://codereview.chromium.org/7003153/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview_utils.js:26: * Returns true if the
contents of the two arrays are equal.
I realize this is cut + paste, but please add the @params here.

http://codereview.chromium.org/7003153/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview_utils.js:159: * Converts |pageSet| to
page ranges. It squashes whenever possible.
Can you keep the example you had before?

[dpapad, 2011-06-13 21:44:02]

http://codereview.chromium.org/7003153/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview_utils.js (right):

http://codereview.chromium.org/7003153/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview_utils.js:26: * Returns true if the
contents of the two arrays are equal.
On 2011/06/13 20:51:51, Lei Zhang wrote:
> I realize this is cut + paste, but please add the @params here.

Done.

http://codereview.chromium.org/7003153/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview_utils.js:159: * Converts |pageSet| to
page ranges. It squashes whenever possible.
On 2011/06/13 20:51:51, Lei Zhang wrote:
> Can you keep the example you had before?

Done.

[commit-bot: I haz the power, 2011-06-14 01:14:58]

Change committed as 88938