chrome/test/functional/media/media_test_matrix.py - Issue 7003131: Adding HTML5 track(caption) test case in PyAuto media functional tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/functional/media/media_test_matrix.py

Issue 7003131: Adding HTML5 track(caption) test case in PyAuto media functional tests. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: adding title for video and set default track file. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/media/html/player.js ('K') | « chrome/test/functional/media/media_test_env_names.py ('k') | chrome/test/functional/media/media_test_runner.py » ('j') | chrome/test/functional/media/media_test_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/functional/media/media_test_matrix.py

diff --git a/chrome/test/functional/media/media_test_matrix.py b/chrome/test/functional/media/media_test_matrix.py

index 0d1cf44901fe7cf33c4fec1c9bccf5db3e133e49..b04a22d1de83bcdbe09468944732da2e9a87411e 100644

--- a/chrome/test/functional/media/media_test_matrix.py

+++ b/chrome/test/functional/media/media_test_matrix.py

@@ -198,7 +198,7 @@ class MediaTestMatrix:

tag = ['audio', 'video'][is_video]

if ((not NOT_AVAILABLE_STRING in info) and

((not video_only) or (video_only and is_video))):

- media_infos.append([tag, url, nickname])

+ media_infos.append([tag, url, nickname, name])

return media_infos

@staticmethod

@@ -216,6 +216,6 @@ class MediaTestMatrix:

(such as bear.webm).

tag: HTML5 tag for the video/audio.

"""

- for tag, url, nickname in compact_list:

+ for tag, url, nickname, title in compact_list:

if target == nickname:

- return (tag, url, nickname)

+ return (tag, url, nickname, title)