Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4750)

Unified Diff: chrome/test/data/media/html/player.js

Issue 7003131: Adding HTML5 track(caption) test case in PyAuto media functional tests. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: adding title for video and set default track file. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/media/html/player.js
diff --git a/chrome/test/data/media/html/player.js b/chrome/test/data/media/html/player.js
index 8f28f44a73632d87fd13a2344b1cac9d9f9a9ac8..0384d8274288d756356f7cdeb920f8a422bfc783 100644
--- a/chrome/test/data/media/html/player.js
+++ b/chrome/test/data/media/html/player.js
@@ -83,6 +83,8 @@ if (queryString('actions')) {
}
}
+
annacc 2011/06/13 18:51:37 extra lines?
imasaki1 2011/06/13 23:43:09 Done.
+
var container = document.getElementById('player_container');
container.innerHTML = '<' + tag + ' controls id="player"></' + tag + '>';
player = document.getElementById('player');
@@ -93,4 +95,16 @@ InstallEventHandler('error',
InstallEventHandler('playing', 'document.title = "PLAYING"');
InstallEventHandler('ended', 'document.title = "END"');
-player.src = media_url;
+player.src = media_url;
+
+if (queryString('track')) {
+ track_file = queryString('track')
dennis_jeffrey 2011/06/13 22:51:49 nit: "var track_file". Also put semi-colon at end
imasaki1 2011/06/13 23:43:09 Done.
+ var trackElement = document.createElement('track');
+ trackElement.setAttribute('id', 'track');
+ trackElement.setAttribute('kind', 'captions');
+ trackElement.setAttribute('src', track_file);
+ trackElement.setAttribute('srclang', 'en');
+ trackElement.setAttribute('label', 'English');
+ trackElement.setAttribute('default', 'true');
+ player.appendChild(trackElement);
+}

Powered by Google App Engine
This is Rietveld 408576698