Print Preview: Set color correctly if there is no printers; Make some optional PDF plugin feature...

chrome/browser/resources/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var localStrings = new LocalStrings();
 
 // The total page count of the previewed document regardless of which pages the
 // user has selected.
 var totalPageCount = -1;
 
@@ skipping 184 matching lines @@
     fadeInElement($('copies-option'));
     $('hr-before-copies').classList.add('invisible');
   }
 
   disableColorOption ? fadeOutElement($('color-options')) :
       fadeInElement($('color-options'));
 
   if (colorOption.checked != setColorAsDefault) {
     colorOption.checked = setColorAsDefault;
     bwOption.checked = !setColorAsDefault;
-    setColor(colorOption.checked);

[Lei Zhang, 2011/06/10 04:11:47]

on first load, this fails because the PDF plugin has not been created yet.

   }
 }
 
 /**
  * Validates the copies text field value.
  * NOTE: An empty copies field text is considered valid because the blur event
  * listener of this field will set it back to a default value.
  * @return {boolean} true if the number of copies is valid else returns false.
  */
 function isNumberOfCopiesValid() {
@@ skipping 250 matching lines @@
 
 /**
  * Called when the PDF plugin loads its document.
  */
 function onPDFLoad() {
   if (isLandscape())
     $('pdf-viewer').fitToWidth();
   else
     $('pdf-viewer').fitToHeight();
 
+  setColor($('color').checked);
+
   hideLoadingAnimation();
 
   if (!previewModifiable)
     fadeOutElement($('landscape-option'));
 
   updateCopiesButtonsState();
 }
 
 /**
  * Update the print preview when new preview data is available.
@@ skipping 49 matching lines @@
  * @param {string} previewUid Preview unique identifier.
  */
 function createPDFPlugin(previewUid) {
   // Enable the print button.
   if (!$('printer-list').disabled) {
     $('print-button').disabled = false;
   }
 
   var pdfViewer = $('pdf-viewer');
   if (pdfViewer) {
-    // Older version of the PDF plugin may not have this method.
-    // TODO(thestig) Eventually remove this check.
-    if (pdfViewer.goToPage) {
-      // Need to call this before the reload(), where the plugin resets its
-      // internal page count.
-      pdfViewer.goToPage('0');
-    }
+    // Need to call this before the reload(), where the plugin resets its
+    // internal page count.
+    pdfViewer.goToPage('0');
+
     pdfViewer.reload();
     pdfViewer.grayscale(!isColor());
     return;
   }
 
   var pdfPlugin = document.createElement('embed');
   pdfPlugin.setAttribute('id', 'pdf-viewer');
   pdfPlugin.setAttribute('type', 'application/pdf');
   pdfPlugin.setAttribute('src', 'chrome://print/' + previewUid + '/print.pdf');
   var mainView = $('mainview');
   mainView.appendChild(pdfPlugin);
   pdfPlugin.onload('onPDFLoad()');
-
-  // Older version of the PDF plugin may not have this method.
-  // TODO(thestig) Eventually remove this check.
-  if (pdfPlugin.removePrintButton) {
-    pdfPlugin.removePrintButton();
-  }
-
+  pdfPlugin.removePrintButton();
   pdfPlugin.grayscale(true);
 }
 
 /**
  * Returns true if a compatible pdf plugin exists, false if it doesn't.
  */
 function checkCompatiblePluginExists() {
   var dummyPlugin = $('dummy-viewer')
-  return !!dummyPlugin.onload;
+  return (dummyPlugin.onload &&
+          dummyPlugin.goToPage &&
+          dummyPlugin.removePrintButton);
 }
 
 /**
  * Updates the state of print button depending on the user selection.
  * The button is enabled only when the following conditions are true.
  * 1) The selected page ranges are valid.
  * 2) The number of copies is valid (if applicable).
  */
 function updatePrintButtonState() {
   if (getSelectedPrinterName() == PRINT_TO_PDF) {
@@ skipping 365 matching lines @@
   this.isLandscape = '';
 }
 
 /**
  * Takes a snapshot of the print settings.
  */
 PrintSettings.prototype.save = function() {
   this.deviceName = getSelectedPrinterName();
   this.isLandscape = isLandscape();
 }