Issue 7003107: Print Preview: Set color correctly if there is no printers; Make some optional PDF plugin feature...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7003107: Print Preview: Set color correctly if there is no printers; Make some optional PDF plugin feature... (Closed)

Created:
9 years, 6 months ago by Lei Zhang

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, dpapad

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Print Preview: Set color correctly if there is no printers; Make some optional PDF plugin feature checks required. BUG=none TEST=On a computer with no printers, Print to PDF defaults to color. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88641

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -16 lines)			Patch
	M	chrome/browser/resources/print_preview.js	View		5 chunks	+10 lines, -16 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/7003107/diff/1/chrome/browser/resources/print_preview.js File chrome/browser/resources/print_preview.js (left): http://codereview.chromium.org/7003107/diff/1/chrome/browser/resources/print_preview.js#oldcode205 chrome/browser/resources/print_preview.js:205: setColor(colorOption.checked); on first load, this fails because the PDF ...

9 years, 6 months ago (2011-06-10 04:11:47 UTC) #1

Change committed as 88641

Expand Messages | Collapse Messages