Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: chrome/browser/extensions/extension_special_storage_policy.cc

Issue 7003098: Start refractoring extension permissions into ExtensionPermissionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix a bad merge Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_special_storage_policy.cc
diff --git a/chrome/browser/extensions/extension_special_storage_policy.cc b/chrome/browser/extensions/extension_special_storage_policy.cc
index fd3ccc4c7090c78569309debb4c272faf231c613..0bb5f735f6819a9844b81d2c636daed4e5685c35 100644
--- a/chrome/browser/extensions/extension_special_storage_policy.cc
+++ b/chrome/browser/extensions/extension_special_storage_policy.cc
@@ -34,16 +34,18 @@ void ExtensionSpecialStoragePolicy::GrantRightsForExtension(
const Extension* extension) {
DCHECK(extension);
if (!extension->is_hosted_app() &&
- !extension->HasApiPermission(Extension::kUnlimitedStoragePermission) &&
- !extension->HasApiPermission(Extension::kFileBrowserHandlerPermission)) {
+ !extension->HasApiPermission(
+ ExtensionAPIPermission::UnlimitedStorage()) &&
+ !extension->HasApiPermission(
+ ExtensionAPIPermission::FileBrowserHandler())) {
return;
}
base::AutoLock locker(lock_);
if (extension->is_hosted_app())
protected_apps_.Add(extension);
- if (extension->HasApiPermission(Extension::kUnlimitedStoragePermission))
+ if (extension->HasApiPermission(ExtensionAPIPermission::UnlimitedStorage()))
unlimited_extensions_.Add(extension);
- if (extension->HasApiPermission(Extension::kFileBrowserHandlerPermission))
+ if (extension->HasApiPermission(ExtensionAPIPermission::FileBrowserHandler()))
file_handler_extensions_.Add(extension);
}
@@ -51,16 +53,18 @@ void ExtensionSpecialStoragePolicy::RevokeRightsForExtension(
const Extension* extension) {
DCHECK(extension);
if (!extension->is_hosted_app() &&
- !extension->HasApiPermission(Extension::kUnlimitedStoragePermission) &&
- !extension->HasApiPermission(Extension::kFileBrowserHandlerPermission)) {
+ !extension->HasApiPermission(
+ ExtensionAPIPermission::UnlimitedStorage()) &&
+ !extension->HasApiPermission(
+ ExtensionAPIPermission::FileBrowserHandler())) {
return;
}
base::AutoLock locker(lock_);
if (extension->is_hosted_app())
protected_apps_.Remove(extension);
- if (extension->HasApiPermission(Extension::kUnlimitedStoragePermission))
+ if (extension->HasApiPermission(ExtensionAPIPermission::UnlimitedStorage()))
unlimited_extensions_.Remove(extension);
- if (extension->HasApiPermission(Extension::kFileBrowserHandlerPermission))
+ if (extension->HasApiPermission(ExtensionAPIPermission::FileBrowserHandler()))
file_handler_extensions_.Remove(extension);
}

Powered by Google App Engine
This is Rietveld 408576698